Don't nudge people towards toilet closures when producing owl results #4313
Conversation
Manishearth
changed the title
|
@bors delegate=yaahallo |
|
✌️ @yaahallo can now approve this pull request |
tests/ui/drop_forget_ref.rs
Outdated
| @@ -55,3 +55,18 @@ fn test_similarly_named_function() { | |||
| forget(&SomeStruct); //OK; call to unrelated function which happens to have the same name | |||
| std::mem::forget(&SomeStruct); | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
| fn test_owl_closure() -> Result<(), ()> { | |||
There was a problem hiding this comment.
I'm not sure if this should be restricted only to owl results instead of all result types with either their ok or err types equal to ()
Manishearth
force-pushed
the
owl
branch
3 times, most recently
from
9e96299 to
b2bdff4
Compare
|
@bors r+ |
|
📌 Commit b2bdff4 has been approved by |
tests/ui/drop_forget_ref.rs
Outdated
| fn test_owl_result_2() -> Result<u8, ()> { | ||
| #[derive(Copy, Clone)] | ||
| pub struct Error; | ||
| fn produce_result() -> Result<(), Error> { |
There was a problem hiding this comment.
This function is never used. Is this intended?
There was a problem hiding this comment.
Made some last minute refactorings that left this behind
|
@bors r=yaahallo |
|
📌 Commit 38e7bd2 has been approved by |
Don't nudge people towards toilet closures when producing owl results `.map_err(drop)` should never be linted since sometimes you want to produce `Result<(), ()>` and the alternative is `.map_err(|_| ())`, which can be ugly. We don't seem to, but it's good to specifically test for this. r? @yaahallo
|
💔 Test failed - checks-travis |
|
@bors r=yaahallo forgot changelog |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 38e7bd2 has been approved by |
Don't nudge people towards toilet closures when producing owl results `.map_err(drop)` should never be linted since sometimes you want to produce `Result<(), ()>` and the alternative is `.map_err(|_| ())`, which can be ugly. We don't seem to, but it's good to specifically test for this. changelog: none r? @yaahallo
|
☀️ Test successful - checks-travis, status-appveyor |
.map_err(drop)should never be linted since sometimes you want to produceResult<(), ()>and the alternative is.map_err(|_| ()), which can be ugly. We don't seem to, but it's good to specifically test for this.changelog: none
r? @yaahallo