Skip to content

appveyor: on_finish run after saving cache #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 17, 2019

According to https://www.appveyor.com/docs/build-configuration/#build-pipeline
on_finish step runs after saving cache step, we should use after_test instead.

changelog: none

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2019

📌 Commit 607f795 has been approved by Manishearth

bors added a commit that referenced this pull request Oct 18, 2019
appveyor: on_finish run after saving cache

According to <https://www.appveyor.com/docs/build-configuration/#build-pipeline>
on_finish step runs after saving cache step, we should use after_test instead.

changelog: none
@bors
Copy link
Contributor

bors commented Oct 18, 2019

⌛ Testing commit 607f795 with merge becbdc8...

@bors
Copy link
Contributor

bors commented Oct 18, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member

phansch commented Oct 18, 2019

@bors retry (mac timeout)

@bors
Copy link
Contributor

bors commented Oct 18, 2019

⌛ Testing commit 607f795 with merge ee6fc1b...

bors added a commit that referenced this pull request Oct 18, 2019
appveyor: on_finish run after saving cache

According to <https://www.appveyor.com/docs/build-configuration/#build-pipeline>
on_finish step runs after saving cache step, we should use after_test instead.

changelog: none
@bors
Copy link
Contributor

bors commented Oct 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing ee6fc1b to master...

@bors bors merged commit 607f795 into rust-lang:master Oct 18, 2019
@tesuji tesuji deleted the before-cache-appveyor branch October 18, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants