Skip to content

rustup cargo install-upgrade #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2019
Merged

rustup cargo install-upgrade #4852

merged 1 commit into from
Nov 27, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Nov 26, 2019

changelog: none

@flip1995
Copy link
Member

Is install now the same as install-upgrade?

@tesuji
Copy link
Contributor Author

tesuji commented Nov 26, 2019

Yes, both are the same.

flip1995
flip1995 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO that's weird behavior for an install command. Well ¯\_(ツ)_/¯

@flip1995 flip1995 added the S-waiting-on-bors Status: The marked PR was approved and is only waiting bors label Nov 26, 2019
@Manishearth Manishearth merged commit 29777b5 into rust-lang:master Nov 27, 2019
@Manishearth
Copy link
Member

manually merging to unblock CI

@tesuji tesuji deleted the cargo_install branch November 28, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesuji @flip1995 @Manishearth