Skip to content

Avoid needless_doctest_main on 'extern crate' #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Dec 23, 2019

This fixes #4927.

r? @flip1995

changelog: none

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to run ./util/dev fmt to satisfy CI. r=me with formatting.

@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Dec 24, 2019
@llogiq llogiq force-pushed the doc-main-extern-crate branch from 154d952 to 129d0cd Compare December 24, 2019 12:42
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 24, 2019

📌 Commit 129d0cd has been approved by flip1995

bors added a commit that referenced this pull request Dec 24, 2019
Avoid needless_doctest_main on 'extern crate'

This fixes #4927.

r? @flip1995
@bors
Copy link
Contributor

bors commented Dec 24, 2019

⌛ Testing commit 129d0cd with merge ec23590...

@bors
Copy link
Contributor

bors commented Dec 24, 2019

💔 Test failed - checks-travis

@llogiq
Copy link
Contributor Author

llogiq commented Dec 24, 2019

@bors retry

@bors
Copy link
Contributor

bors commented Dec 24, 2019

⌛ Testing commit 129d0cd with merge a68ef55...

bors added a commit that referenced this pull request Dec 24, 2019
Avoid needless_doctest_main on 'extern crate'

This fixes #4927.

r? @flip1995

changelog: none
@bors
Copy link
Contributor

bors commented Dec 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing a68ef55 to master...

@bors bors merged commit 129d0cd into master Dec 24, 2019
@flip1995 flip1995 deleted the doc-main-extern-crate branch December 24, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needless_doctest_main suggestion wrong with explicit extern crate
4 participants