Skip to content

perform system upgrade fixes ci issue #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

perform system upgrade fixes ci issue #5478

merged 1 commit into from
Apr 16, 2020

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Apr 16, 2020 •
edited
Loading

Perhaps doing a system upgrade magically solves the problem?

changelog: none

@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Apr 16, 2020

⌛ Trying commit 31061ff with merge 90a45b9...

bors added a commit that referenced this pull request Apr 16, 2020
@bors
Auto merge of #5478 - matthiaskrgr:apt_ci_debug_5477, r=<try>
90a45b9 
[TEST] see if performing system upgrade fixes ci issue

DO NOT MERGE

Perhaps doing a system upgrade magically solves the problem?
@bors
Copy link
Contributor

bors commented Apr 16, 2020

💔 Test failed - checks-action_test

@matthiaskrgr matthiaskrgr mentioned this pull request Apr 16, 2020
Closed
@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Apr 16, 2020

⌛ Trying commit 31061ff with merge 32becdd...

bors added a commit that referenced this pull request Apr 16, 2020
@bors
Auto merge of #5478 - matthiaskrgr:apt_ci_debug_5477, r=<try>
32becdd 
[TEST] see if performing system upgrade fixes ci issue

DO NOT MERGE

Perhaps doing a system upgrade magically solves the problem?

changelog: none
@bors
Copy link
Contributor

bors commented Apr 16, 2020

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 32becdd (32becdd3444f3981fa0d6d544cfbb94eb253e27c)

flip1995
flip1995 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree with this change, with a note, that this can (maybe) be removed in the future. @phansch

.github/workflows/clippy_bors.yml
@@ -77,6 +77,7 @@ jobs:
run: |
sudo dpkg --add-architecture i386
sudo apt-get update
sudo apt-get -y upgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This costs ~2 min of CI time. I think this is ok, since the integration tests take about 16 minutes and this check with this change ~12min.

@matthiaskrgr
Copy link
Member Author

Yeah, I also think we should revert this as soon as the underlying issue is resolved...

@matthiaskrgr matthiaskrgr changed the title [TEST] see if performing system upgrade fixes ci issue perform system upgrade fixes ci issue Apr 16, 2020
@matthiaskrgr
Copy link
Member Author

@bors try

bors added a commit that referenced this pull request Apr 16, 2020
@bors
Auto merge of #5478 - matthiaskrgr:apt_ci_debug_5477, r=<try>
8980825 
 perform system upgrade fixes ci issue

Perhaps doing a system upgrade magically solves the problem?

changelog: none
@bors
Copy link
Contributor

bors commented Apr 16, 2020

⌛ Trying commit d181fde with merge 8980825...

phansch
phansch approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@phansch phansch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seems fine to me, thanks! (let's wait for the second try run to finish)

@bors
Copy link
Contributor

bors commented Apr 16, 2020

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 8980825 (898082582383f2dcd279440c9adfbaf5f65d293d)

@flip1995
Copy link
Member

@bors r=phansch,flip1995

Let's merge this, we already have 4 PRs in queue waiting for this 👍

@bors
Copy link
Contributor

bors commented Apr 16, 2020

📌 Commit d181fde has been approved by phansch,flip1995

@bors
Copy link
Contributor

bors commented Apr 16, 2020

🌲 The tree is currently closed for pull requests below priority 2, this pull request will be tested once the tree is reopened

@flip1995
Copy link
Member

@bors treeclosed-

@flip1995
Copy link
Member

@bors p=2 retry

@bors
Copy link
Contributor

bors commented Apr 16, 2020

⌛ Testing commit d181fde with merge da14f1e...

@bors bors mentioned this pull request Apr 16, 2020
Merged
@bors
Copy link
Contributor

bors commented Apr 16, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch,flip1995
Pushing da14f1e to master...

@bors bors merged commit da14f1e into rust-lang:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @bors @flip1995 @phansch