Add lint for "string literal".as_bytes() #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs a macro check. Apart from that I'm OK with |
|
r+ w/ macro check |
|
@llogiq You're right. Done. |
|
I'd actually use |
fhartwig
force-pushed
the
str-lit-as-bytes
branch
from
b88cebf to
ea26ae3
Compare
|
@llogiq Right, sorry. I somehow didn't see |
llogiq
added a commit
that referenced
this pull request
Jan 19, 2016
Add lint for "string literal".as_bytes()
|
Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560
I've made this
Warnby default because I think byte string literals should be strictly preferred. Let me know if you think it should beAllow, since this is somewhat subjective.