Add a lint about deriving Hash and implementing PartialEq #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// **What it does:** This lint warns about deriving `Hash` but implementing `PartialEq` | ||
| /// explicitely. | ||
| /// | ||
| /// **Why is this bad?** The implementation of these traits must agree so it’s probably a bad idea |
There was a problem hiding this comment.
Could we have a more detailed explanation here? cc @gankro
There was a problem hiding this comment.
No problem. Is it better?
| /// **Why is this bad?** The implementation of these traits must agree (for example for use with | ||
| /// `HashMap`) so it’s probably a bad idea to use a default-generated `Hash` implementation with | ||
| /// an explicitely defined `PartialEq`. In particular, the following must hold for any type: | ||
| /// ```rust |
There was a problem hiding this comment.
there should be a linebreak before this
Manishearth
added a commit
that referenced
this pull request
Jan 22, 2016
Add a lint about deriving Hash and implementing PartialEq
|
We can also do something similar for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #430.