Skip to content

Update ui stderr with improved rustc output #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Sep 3, 2020
Merged

Update ui stderr with improved rustc output #6003

merged 1 commit into from Sep 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 3, 2020

Related rust pull request: rust-lang/rust#76160

changelog: none

@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 3, 2020
@phansch
Copy link
Member

phansch commented Sep 3, 2020

r? @phansch

@rust-highfive rust-highfive assigned phansch and unassigned Manishearth Sep 3, 2020
@phansch
Copy link
Member

phansch commented Sep 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 3, 2020

📌 Commit 93ce686 has been approved by phansch

@bors
Copy link
Contributor

bors commented Sep 3, 2020

⌛ Testing commit 93ce686 with merge a31216b...

@bors
Copy link
Contributor

bors commented Sep 3, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing a31216b to master...

@bors bors merged commit a31216b into rust-lang:master Sep 3, 2020
@scrabsha
Copy link
Contributor

scrabsha commented Sep 3, 2020

I'm the author of rust-lang/rust#76160. This is my second non-doc contribution to rust, and I lack experience in OSS in general.

Was I supposed to open such PR myself?

@ebroto
Copy link
Member

ebroto commented Sep 4, 2020

@scileo not necessarily :)

When changes in rustc break Clippy, the in-tree version of Clippy must be fixed, and you already did that 👍
Syncing back those changes to this repo is Clippy's responsibility and can be done by anyone, see CONTRIBUTING.md.

@scrabsha
Copy link
Contributor

scrabsha commented Sep 6, 2020 •
edited
Loading

@ebroto thank you for your explanations. Next time I'll open a PR there too :)

@ghost ghost deleted the fix-tests-20200903 branch September 17, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phansch phansch

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rust-highfive @phansch @bors @scrabsha @ebroto @Manishearth