Fix ICE in EXPL_IMPL_CLONE_ON_COPY
#667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ICE goes away, thanks! |
Manishearth
added a commit
that referenced
this pull request
Feb 15, 2016
Fix ICE in `EXPL_IMPL_CLONE_ON_COPY`
|
After the 100th lint, the 1000th commit 🍰 |
|
whoa nice 💯 🎊 :D |
|
I don't think this is the correct solution but a hacky band-aid. |
|
Generics make the situation a bit more complicated anyway so the band aid is okay with me. But yeah, perhaps we should try that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores generics with lifetimes. The built-in
MISSING_COPY_IMPLEMENTATIONSlint ignores lifetimes¹, I guess there must be reasons we can’t use them.Closes #666.
1 : ignores all generics really, but we have tests for generics without lts and it works™.