Remove hidden code lines in Clippy's lint list #7887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
7172-hiding-hidden-lines-online
branch
from
7f793aa to
dea9402
Compare
And I implemented this (ignoring "# ") last time in the python doc gen script. 😄 @bors r+ Thanks! |
|
📌 Commit dea9402 has been approved by |
|
The old python script ^^. I actually didn't know that the script supported this. Nice 👍 |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
I've scanned through the gh-pages commit 48e7fe7 and everything is looking fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes code lines from Clippy's lint list, which would also be hidden, when generating docs with rustdoc.
"A picture is worth a thousand words"... and here are even two pictures:
Before:
After:
changelog: none
r? @camsteffen (Since you implemented the code block filtering 🙃 )