Skip to content

Don't check for a nightly toolchain in fmt test #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 20, 2021

changelog: None

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 20, 2021
@llogiq
Copy link
Contributor

llogiq commented Nov 20, 2021

What's the rationale for this?

@Jarcho
Copy link
Contributor Author

Jarcho commented Nov 20, 2021

There's already a pinned nightly version and dev fmt uses that version.

@llogiq
Copy link
Contributor

llogiq commented Nov 20, 2021

Ah, I see. Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2021

📌 Commit 1429949 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Nov 20, 2021

⌛ Testing commit 1429949 with merge 827fd50...

@bors
Copy link
Contributor

bors commented Nov 20, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 827fd50 to master...

@bors bors merged commit 827fd50 into rust-lang:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants