fix ICE in cast_slice_different_sizes
#8720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Alexendoo |
Alexendoo
reviewed
Apr 19, 2022
…bugs in displaying an extra mut when a TypeAndMut was wrong
asquared31415
force-pushed
the
ptr-cast-ice-fix
branch
from
d9a974c to
af9dfa3
Compare
Alexendoo
reviewed
Apr 23, 2022
Alexendoo
approved these changes
Apr 25, 2022
|
Thanks! LGTM @xFrednet |
xFrednet
reviewed
Apr 28, 2022
There was a problem hiding this comment.
Looks good to me, I found one small NIT, that should be easy to fix. Then this can be merged.
Thank you, @Alexendoo, for the review!
xFrednet
approved these changes
Apr 30, 2022
|
This looks good to me, thank you very much! 👍 @bors r=Alexendoo,xFrednet |
|
📌 Commit 8f8fc9f has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8708
changelog: fixes an ICE introduced in #8445