feat(fix): ignore todo! and unimplemented! in if_same_then_else
#9006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
kyoto7250
changed the title
todo! and unimplemented! in if_same_then_else
Jarcho
reviewed
Jun 16, 2022
Jarcho
requested changes
Jun 17, 2022
|
I did some commits. Could I request another review? |
Jarcho
requested changes
Jun 18, 2022
|
Looks good. @bors r+ |
|
📌 Commit 39ffda0 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #8836
take over: #8853
This PR adds check
todo!andunimplemented!in if_same_then_else.( I thought
unimplementedshould not be checked as well as todo!.)Thank you in advance.
changelog: ignore todo! and unimplemented! in if_same_then_else
r? @Jarcho