Skip to content

Regexes #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2016
Merged

Regexes #955

merged 2 commits into from
May 25, 2016

Conversation

mcarton
Copy link
Member

@mcarton mcarton commented May 25, 2016

invalid_regex and trivial_regex can now warn on RegexSet::new, Regex::with_size_limit, RegexBuilder::new and both unicode and byte regexes (before only regex::re_unicode::Regex::new was considered).

Cc @BurntSushi.

@BurntSushi
Copy link
Member

Note that Regex::with_size_limit will probably be going away soon once 1.0 lands. You'll probably want to lint RegexBuilder and bytes::RegexBuilder instead.

@mcarton
Copy link
Member Author

mcarton commented May 25, 2016

Thanks for pointing that out, done.

@llogiq
Copy link
Contributor

llogiq commented May 25, 2016

I'm a tiny bit annoyed that I didn't come up with this myself, given that I introduced regex::bytes to the benchmarksgame's regex-dna entry...but I'm still happy you built it. 👍

@llogiq llogiq merged commit 4c34732 into master May 25, 2016
@llogiq llogiq deleted the regexes branch May 25, 2016 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants