Skip to content

Update Applicability of redundant_allocation lint from MachineApplicable to MaybeIncorrect #9634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2022
Merged

Update Applicability of redundant_allocation lint from MachineApplicable to MaybeIncorrect #9634

merged 1 commit into from
Oct 19, 2022

Conversation

roynrishingha
Copy link
Contributor

@roynrishingha roynrishingha commented Oct 12, 2022 •
edited
Loading

This changes redundant_allocation lint from MachineApplicable to MaybeIncorrect

changelog: [`redundant_allocation]: Change Applicability from MachineApplicable to MaybeIncorrect

fixes #6243

changelog: [redundant_allocation]: Change Applicability from MachineApplicable to MaybeIncorrect

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 12, 2022
@roynrishingha
Copy link
Contributor Author

r? @llogiq

@rust-highfive rust-highfive assigned llogiq and unassigned Manishearth Oct 12, 2022
@kraktus
Copy link
Contributor

kraktus commented Oct 15, 2022

Unspecified is only for lints we haven't assessed if they have false positive or not. If we know for sure there are some FPs better to use MaybeIncorrect.

@Manishearth
Copy link
Member

r? @Manishearth

@rust-highfive rust-highfive assigned Manishearth and unassigned llogiq Oct 17, 2022
Manishearth
Manishearth requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this should be MaybeIncorrect.

Would be nice to have a fourth NonLocal variant on Applicability

@roynrishingha
Update Applicability of redundant_allocation lint from
1da1ff6 
`MachineApplicable` to `Unspecified`
@roynrishingha roynrishingha changed the title Update Applicability of redundant_allocation lint from MachineApplicable to Unspecified Update Applicability of redundant_allocation lint from MachineApplicable to MaybeIncorrect Oct 19, 2022
@roynrishingha
Copy link
Contributor Author

@Manishearth @llogiq I changed it into MaybeIncorrect.

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2022

📌 Commit 1da1ff6 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 19, 2022

⌛ Testing commit 1da1ff6 with merge 1afc7e2...

@bors
Copy link
Contributor

bors commented Oct 19, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 1afc7e2 to master...

@bors bors merged commit 1afc7e2 into rust-lang:master Oct 19, 2022
@roynrishingha roynrishingha deleted the fix_redundant_allocation branch April 20, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Manishearth Manishearth

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redundant_allocation should not be marked as machine applicable
6 participants
@roynrishingha @rust-highfive @kraktus @Manishearth @bors @llogiq