syntax checking fails (silently) when cargo is not in default path

[conundrumer]

SyntaxCheckPlugin was not able to find cargo, but doesn't report not being able to find it, because the actual error message is /bin/sh: cargo: command not found, whereas the error checker looks for "error".

I installed Rust through rustup, so cargo is in $HOME/.cargo/bin. But the path of SyntaxCheckPlugin is the default: /usr/bin:/bin:/usr/sbin:/sbin. #92 did not address this plugin.

[jasonwilliams]

@conundrumer interesting, we don't hardcode the path, so looks like the script isn't picking up the system path

[dten]

Seems we do set the path but only on OSX https://github.com/rust-lang/sublime-rust/blob/master/Cargo.sublime-build#L8
So I guess everyone on OSX build would work without changes but syntax check won't. Everybody else has to have cargo on the path beforehand.

[jasonwilliams]

@conundrumer what OS are you running this on?

[conundrumer]

@Jayflux this is on OSX. I will also note that the path to $HOME/.cargo/bin is set on my .bashrc. Also, the build commands work.

[jasonwilliams]

I will run a couple of tests on my macbook and windows 10 later on, and see what the problem is.
Sounds like the script isn't seeing the outer path

[jcagpir]

I have the same problem with Manjaro (ArchLinux based).
My shell path is : ".../usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/lib32/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/go/bin:/home/jcag/.cargo/bin"

"/home/jcag/.cargo/bin" is Cargo installation path, but when I try to build a rust file Sublime Text doesn't get the right value of the shell path and I get the message :
"[Errno 2] No such file or directory: 'cargo'"
...
"[path: /usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/lib32/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/go/bin]"

[jasonwilliams]

@wbond is it possible to get the user's env variables into the context of a sublime plugin?

[wbond]

This only occurs on OS X because all applications are launched from the dock, which does not execute your shell, and thus does not have the same environment.

There is an enhancement that will be part of the next dev build that executes the user's default shell as a login shell and fetches their environment variables to get around this limitation of OS X.

[jcagpir]

@wbond
It seems it occurs in Linux manjaro too. Here is the whole error message when I try to build "guessing_game" project:

"[Errno 2] No such file or directory: 'cargo'
[cmd: ['cargo', 'run'] // not "shell_cmd"
[dir: /home/jcag/Rust/Projects/guessing_game/src]
[path: /usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/lib32/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/go/bin]
[Finished]"

But my shell path is :

".../usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/lib32/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/go/bin:/home/jcag/.cargo/bin"

and "/home/jcag/.cargo/bin" is my Cargo installation path.
Sublime Text (Build 3126) is launched from the application menu and Rust Enhanced plugin was installed by Package Control.
What can I do ? Thanks in advance.

[wbond]

@jcagpir That means that your env for your DE isn't set properly. It isn't really up to Sublime Text to manage that for you. In fact, it seems you've gotten your env set properly for Go, Java and Perl. You just need to configure Rust also.

We are adding the work-around for OS X since there isn't really a reasonable way to set the environment of the Dock process. There were some changes that worked on some versions of OS X, but it didn't work in many situations.

[jcagpir]

@wbond Thanks for your answer.
Path env variable must be configured into "home/UserName/.bash_profile" file an not in "home/UserName/.bashrc". It consists in adding the line "export PATH=$PATH:/home/UserName/.cargo/bin"

[jasonwilliams]

@conundrumer @jcagpir is this still a problem on the latest release?

[jasonwilliams]

@conundrumer @jcagpir did the fix in #97 not address your issue?

[jasonwilliams]

ok looks like the issue is still there....
Im wondering if we can add ~/.cargo/bin to the path before we spawn the process?

I might give it a go as an experiment

http://stackoverflow.com/questions/2231227/python-subprocess-popen-with-a-modified-environment

[jasonwilliams]

Provided a fix here: #166
Seems to work for me