Skip to content

Next Result / Previous Result (F4 / Shift + F4) don't work when "show_errors_inline" is false #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madadam opened this issue Sep 7, 2017 · 1 comment · Fixed by #207

Comments

@madadam
Copy link

madadam commented Sep 7, 2017

Some people might prefer to disable inline errors (myself included), but that breaks the "Next Result" and "Previous Result" commands. My guess is that it happens because the non-inline error output doesn't conform to the pattern that Rust Enhanced expects.

This is how the error output looks like:

error[E0425]: cannot find function `helo` in this scope
 --> src/main.rs:3:5
  |
3 |     helo()
  |     ^^^^ did you mean `hello`?

Problem is probably the --> thing at the beginning of the line.

I was trying to fix this by adding a custom file_regex entry to Rust Enhanced.sublime-build, but it didn't work because the custom command used (cargo_exec) doesn't recognize that option.

@ehuss
Copy link

ehuss commented Sep 9, 2017

Thanks for the report. I have a fix, and I'll post a PR soon. There are a few other issues and I want to make sure they are taken care of.

ehuss added a commit to ehuss/sublime-rust that referenced this issue Sep 10, 2017
ehuss added a commit to ehuss/sublime-rust that referenced this issue Sep 23, 2017
jasonwilliams pushed a commit that referenced this issue Oct 28, 2017
* Sort build messages by level for next/prev shortcuts.

* Add tests for next/prev message order.

* Update for rust 1.22.

* Next/Prev message support when show_errors_inline is False.

Fixes #206.

* Add undocumented config variable to disable message sorting.

* Support scrolling the build output panel on next/prev message.

* Fix on-save checking when show_errors_inline is false.

To disable on-save checking, set rust_syntax_checking to false.

* Next/Prev message cycles through test errors.

* Ensure that all views are closed after running tests.

* Fix cyclic import.

* Fix test errors that panic outside of the crate.

Rust display the source file to the outside crate, which probably isn't
available in the current workspace.  Next/Prev message was opening a
non-existent file.

* Fix Next/Prev overriding find-in-files next/prev result.

Fixes #209.
urschrei pushed a commit to urschrei/sublime-rust that referenced this issue Jan 30, 2018
* Sort build messages by level for next/prev shortcuts.

* Add tests for next/prev message order.

* Update for rust 1.22.

* Next/Prev message support when show_errors_inline is False.

Fixes rust-lang#206.

* Add undocumented config variable to disable message sorting.

* Support scrolling the build output panel on next/prev message.

* Fix on-save checking when show_errors_inline is false.

To disable on-save checking, set rust_syntax_checking to false.

* Next/Prev message cycles through test errors.

* Ensure that all views are closed after running tests.

* Fix cyclic import.

* Fix test errors that panic outside of the crate.

Rust display the source file to the outside crate, which probably isn't
available in the current workspace.  Next/Prev message was opening a
non-existent file.

* Fix Next/Prev overriding find-in-files next/prev result.

Fixes rust-lang#209.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants