Skip to content

Add compiler suggestions and message themes. #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2018

Conversation

ehuss
Copy link

@ehuss ehuss commented Mar 29, 2018

This adds two new features:

  • Suggestions: The ability to click a button to accept a suggestion from the compiler.
  • Themes: Adds a new "solid" style for messages.

Example of the new theme and the suggestions:
image

Other important changes:

  • This adds Package Control "messages" to display a message when the user upgrades, including an important note that the user needs to restart Sublime for the upgrade to work. NOTE: I marked this as release 2.11 assuming it would ride the next release, but this can be adjusted as needed. Also, I think it might be a good idea to continue updating the messages in the future for important changes.
  • Added some logic so that future upgrades will not require restarting Sublime (see plugin_unloaded).
  • Cleanup of the message code, which includes "batches" of messages needed to support suggestions and the new theme.
  • Added a dedicated documentation page to describing how you can configure compiler messages.
  • Minor updates for changes in messages in nightly Rust.

@jasonwilliams
Copy link
Member

I've tested this and it seems to work pretty well!
Merging

@jasonwilliams jasonwilliams merged commit 65a5c32 into rust-lang:master Apr 22, 2018
@ehuss ehuss mentioned this pull request Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants