Avoid learning the same job multiple times #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current learning implementation was designed with Travis CI in mind, where a single check was sent when the job ended. Because of that, when a successful build was detected all the successful job outputs were learned. This assumption doesn't hold anymore for GitHub Actions though. GHA sends a check for every job in the matrix, and that causes RLA to learn a successful job every time one of the following jobs in the same build finishes, learning it multiple times. For example, if a build contains 60 jobs, the first job to finish will be learned 60 times. This fixes the problem by remembering which job IDs we learned before, and skipping the learning process if the ID was previously seen. Along with that the code to remember IDs was refactored.
pietroalbini
force-pushed
the
multiple-learning
branch
from
2b88a0d to
4d64493
Compare
|
Addressed all the feedback. |
Mark-Simulacrum
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current learning implementation was designed with Travis CI in mind, where a single check was sent when the job ended. Because of that, when a successful build was detected all the successful job outputs were learned. This assumption doesn't hold anymore for GitHub Actions though.
GHA sends a check for every job in the matrix, and that causes RLA to learn a successful job every time one of the following jobs in the same build finishes, learning it multiple times. For example, if a build contains 60 jobs, the first job to finish will be learned 60 times.
This fixes the problem by remembering which job IDs we learned before, and skipping the learning process if the ID was previously seen. Along with that the code to remember IDs was refactored.
r? @Mark-Simulacrum