Skip to content

Remove message posted on failures #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Remove message posted on failures #54

merged 3 commits into from
Dec 17, 2020

Conversation

pietroalbini
Copy link
Member

This PR rewords the message posted by the bot when a failure happens to be more concise. There are two reasons for this:

  • The old message contained a lot of extra information that was not really needed to address the failure, which added noise.
  • Having a new message signals to the reviewer that "something changed", hopefully making them notice that we finally fixed RLA and its suggestions are now really reliable.

2020-12-17--12-02-11

The PR also removes the custom HTML log viewer, as that's broken with GitHub Actions and can't really be fixed (due to the logs requiring authentication). If we ever want to fix it we'll need to store the logs ourselves and possibly implement the viewer on the Rust application side.

r? @Mark-Simulacrum

The log viewer does not work with GitHub Actions, as the link to the
logs requires authentication.
@Mark-Simulacrum
Copy link
Member

We'll also want to disable github pages here - this looks good to me other than that though.

I might remove the "of your PR" from the message but it's a minor nit.

@pietroalbini
Copy link
Member Author

Updated the message and disabled GitHub Pages!

@pietroalbini pietroalbini merged commit 328e1ec into master Dec 17, 2020
@pietroalbini pietroalbini deleted the reword-message branch December 17, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants