Prevent expanding the window size when adjusting the split #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we were rotating the *entire* gutter, it would easily extend beyond the window boundaries, adding a scrollbar to the entire playground. Instead, rotate only the handle icon itself. Due to [a limitation with split.js][limitation], we have to also ignore pointer events on the handle since it's now a child of the gutter. [limitation]: nathancahill/split#354
shepmaster
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we were rotating the entire gutter, it would easily extend
beyond the window boundaries, adding a scrollbar to the entire
playground. Instead, rotate only the handle icon itself. Due to a
limitation with split.js, we have to also ignore pointer
events on the handle since it's now a child of the gutter.