Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Pin nightly version to a latest one known to be working #132

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented Oct 12, 2020

Lightweight version of #131 - it'd be good to start with a good working base and incrementally work from there.

r? @Manishearth

@Xanewok
Copy link
Member Author

Xanewok commented Oct 12, 2020

It's worth noting that I used the same cargo bisect-rustc tool from #131 but with test script rather than check - there were some changes wrt Eq and StructuralEq that needed addressing in nightly-2020-06-10 suggested there; atm this version (nightly-2020-06-01) is what builds and passes current tests.

@Manishearth
Copy link
Member

Hmm, CI still fails, but r=me if you can get it to pass

@Xanewok
Copy link
Member Author

Xanewok commented Oct 12, 2020

That's because it tests using the newest nightly with rustup-toolchain-install-master: https://github.com/rust-dev-tools/rust-semverver/blob/0bbdabfc883a4e5c4d6dce21800b01649f0a70fa/ci/run.sh#L10-L21

If you don't mind, I'd prefer to change the CI script to just cargo test (that accounts for rust-toolchain) and then re-introduce the daily CI check using rustup-toolchain-install-master later at some point

@Xanewok
Copy link
Member Author

Xanewok commented Oct 12, 2020

CI is green now, merging as per above

@Xanewok Xanewok merged commit f3a00f9 into rust-lang:master Oct 12, 2020
@Xanewok Xanewok deleted the pin-version branch October 12, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants