This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Track Cargo lockfile and deduplicate Cargo-related dependencies #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason for not including one for library crates is because it's not going to be respected by the final binary or transient library. However, since we also publish a binary, it's worthwhile to track it ourselves.
|
(I don't have time to review, feel free to tag others or self-merge minor stuff) |
|
oops should have bors'd. old habits :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We include Cargo.lock because we also contain a binary and so it makes sense to also track lockfile ourselves, even if it's not going to be respected by dependent crates. This also helped me deduplicate some crates that are shared with Cargo-the-library.
r? @Manishearth or @ibabushkin