---

yaml
---
r: 12534
b: refs/heads/master
c: cd2effe
h: refs/heads/master
v: v3

Author: catamorphism

[refs]

@@ -1,5 +1,5 @@
 ---
-refs/heads/master: 37ea010b0d9e8cbccbe040134708028e6bb05c48
+refs/heads/master: cd2effe0225c6174880716d949c6afe7cb251577
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
 refs/heads/try: 2898dcc5d97da9427ac367542382b6239d9c0bbf

trunk/src/librustsyntax/attr.rs

@@ -192,6 +192,7 @@ fn eq(a: @ast::meta_item, b: @ast::meta_item) -> bool {
           }
           ast::meta_list(na, la) {
 
+            // [Fixme-sorting]
             // FIXME (#607): Needs implementing
             // This involves probably sorting the list by name and
             // meta_item variant
@@ -257,6 +258,7 @@ fn last_meta_item_list_by_name(
 /* Higher-level applications */
 
 // FIXME: This needs to sort by meta_item variant in addition to the item name
+// (See [Fixme-sorting])
 fn sort_meta_items(items: [@ast::meta_item]) -> [@ast::meta_item] {
     fn lteq(&&ma: @ast::meta_item, &&mb: @ast::meta_item) -> bool {
         fn key(m: @ast::meta_item) -> ast::ident {

trunk/src/librustsyntax/ext/env.rs

@@ -21,7 +21,7 @@ fn expand_syntax_ext(cx: ext_ctxt, sp: codemap::span, arg: ast::mac_arg,
         cx.span_fatal(sp, "malformed #env call");
     }
     // FIXME: if this was more thorough it would manufacture an
-    // option<str> rather than just an maybe-empty string.
+    // option<str> rather than just an maybe-empty string. (Issue #2248)
 
     let var = expr_to_str(cx, args[0], "#env requires a string");
     alt os::getenv(var) {

trunk/src/librustsyntax/ext/expand.rs

@@ -98,7 +98,7 @@ fn new_span(cx: ext_ctxt, sp: span) -> span {
 // FIXME: this is a terrible kludge to inject some macros into the default
 // compilation environment. When the macro-definition system is substantially
 // more mature, these should move from here, into a compiled part of libcore
-// at very least.
+// at very least. (Issue #2247)
 
 fn core_macros() -> str {
     ret

trunk/src/librustsyntax/ext/fmt.rs

@@ -42,6 +42,7 @@ fn expand_syntax_ext(cx: ext_ctxt, sp: span, arg: ast::mac_arg,
 // be factored out in common with other code that builds expressions.
 // FIXME: Cleanup the naming of these functions
 // NOTE: Moved many of the common ones to build.rs --kevina
+// See Issue #2249
 fn pieces_to_expr(cx: ext_ctxt, sp: span, pieces: [piece], args: [@ast::expr])
    -> @ast::expr {
     fn make_path_vec(_cx: ext_ctxt, ident: ast::ident) -> [ast::ident] {
@@ -125,7 +126,7 @@ fn pieces_to_expr(cx: ext_ctxt, sp: span, pieces: [piece], args: [@ast::expr])
     }
     fn make_new_conv(cx: ext_ctxt, sp: span, cnv: conv, arg: @ast::expr) ->
        @ast::expr {
-        // FIXME: Extract all this validation into extfmt::ct
+        // FIXME: Move validation code into core::extfmt (Issue #2249)
 
         fn is_signed_type(cnv: conv) -> bool {
             alt cnv.ty {

trunk/src/librustsyntax/ext/simplext.rs

@@ -456,7 +456,8 @@ fn p_t_s_rec(cx: ext_ctxt, m: matchable, s: selector, b: binders) {
               }
             }
           }
-          /* FIXME: handle embedded types and blocks, at least */
+          /* FIXME: handle embedded types and blocks, at least
+             (Issue #2251) */
           expr_mac(mac) {
             p_t_s_r_mac(cx, mac, s, b);
           }
@@ -715,7 +716,7 @@ fn add_new_extension(cx: ext_ctxt, sp: span, arg: ast::mac_arg,
                            body: elts[1u]}];
 
                     // FIXME: check duplicates (or just simplify
-                    // the macro arg situation)
+                    // the macro arg situation) (Issue #2251)
                   }
                   _ {
                       cx.span_bug(mac.span, "undocumented invariant in \