Skip to content

Commit fc0aa74

Browse files
authored
Unrolled build for #142844
Rollup merge of #142844 - dpaoliello:short-ice, r=jieyouxu Enable short-ice for Windows Works fine for x64 without modifications. x86 MSVC is still failing. Addresses item in #128602 --- try-job: x86_64-mingw-* try-job: x86_64-msvc-* try-job: i686-msvc-*
2 parents 2c2bb99 + 4c7f054 commit fc0aa74

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

tests/run-make/short-ice/rmake.rs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
// See https://github.com/rust-lang/rust/issues/107910
66

77
//@ needs-target-std
8-
//@ ignore-windows
9-
// Reason: the assert_eq! on line 32 fails, as error output on Windows is different.
8+
//@ ignore-i686-pc-windows-msvc
9+
// Reason: the assert_eq! on line 37 fails, almost seems like it missing debug info?
10+
// Haven't been able to reproduce locally, but it happens on CI.
1011

1112
use run_make_support::rustc;
1213

@@ -29,10 +30,16 @@ fn main() {
2930

3031
let rustc_query_count_full = count_lines_with(rust_test_log_2, "rustc_query_");
3132

32-
assert!(rust_test_log_1.lines().count() < rust_test_log_2.lines().count());
33+
assert!(
34+
rust_test_log_1.lines().count() < rust_test_log_2.lines().count(),
35+
"Short backtrace should be shorter than full backtrace.\nShort backtrace:\n\
36+
{rust_test_log_1}\nFull backtrace:\n{rust_test_log_2}"
37+
);
3338
assert_eq!(
3439
count_lines_with(rust_test_log_2, "__rust_begin_short_backtrace"),
35-
count_lines_with(rust_test_log_2, "__rust_end_short_backtrace")
40+
count_lines_with(rust_test_log_2, "__rust_end_short_backtrace"),
41+
"Full backtrace should contain the short backtrace markers.\nFull backtrace:\n\
42+
{rust_test_log_2}"
3643
);
3744
assert!(count_lines_with(rust_test_log_1, "rustc_query_") + 5 < rustc_query_count_full);
3845
assert!(rustc_query_count_full > 5);

0 commit comments

Comments
 (0)