Skip to content

Enable short-ice for Windows #142844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Enable short-ice for Windows #142844

merged 1 commit into from
Jun 25, 2025
+11 −4

Conversation

dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Jun 21, 2025 •
edited
Loading

Works fine for x64 without modifications.

x86 MSVC is still failing.

Addresses item in #128602

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

This PR modifies run-make tests.

cc @jieyouxu

@Noratrieb
Copy link
Member

Noratrieb commented Jun 21, 2025 •
edited
Loading

(does bors2 support try-jobs in the description or only in the command? let's see. looks like it does!)
@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 21, 2025

⌛ Trying commit ac55186 with merge b3a3974…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 21, 2025
@rust-bors
Auto merge of #142844 - dpaoliello:short-ice, r=<try>
b3a3974 
Enable short-ice for Windows

Works fine with MSVC without modifications.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

💔 Test failed

@jieyouxu
Copy link
Member

@bors2 delegate=try

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

@dpaoliello can now perform try builds on this pull request

@jieyouxu
Copy link
Member

I vaguely remember this, maybe the backtrace is somehow different in i686 msvc?
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@dpaoliello dpaoliello marked this pull request as draft June 23, 2025 19:36
@dpaoliello
Copy link
Contributor Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

⌛ Trying commit a303bed with merge 86d5cbc…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 23, 2025
@rust-bors
Auto merge of #142844 - dpaoliello:short-ice, r=<try>
86d5cbc 
Enable short-ice for Windows

Works fine with MSVC without modifications.

Addresses item in #128602

---

x86_64-mingw-*
x86_64-msvc-*
try-job: i686-msvc-*
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

💔 Test failed

@dpaoliello
Copy link
Contributor Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

⌛ Trying commit 9e45323 with merge b01f6f1…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 23, 2025
@rust-bors
Auto merge of #142844 - dpaoliello:short-ice, r=<try>
b01f6f1 
Enable short-ice for Windows

Works fine with MSVC without modifications.

Addresses item in #128602

---

x86_64-mingw-*
x86_64-msvc-*
try-job: i686-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

💔 Test failed

@dpaoliello
Copy link
Contributor Author

I vaguely remember this, maybe the backtrace is somehow different in i686 msvc?

Yes, x86 MSVC is different, and I don't understand why. I can't repro it locally, it almost seems like it's not getting the debug info when in the lab.

I've tried on a clean Server 2022 image and still can't reproduce it.

For now, I've left it disabled for x86 MSVC.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2025
@jieyouxu
Copy link
Member

Yeah, that's fine with me.

@jieyouxu
Copy link
Member

@dpaoliello can u take this PR out of draft so bors will let this go through? r=me

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

✌️ @dpaoliello, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@dpaoliello dpaoliello marked this pull request as ready for review June 25, 2025 00:15
@dpaoliello
Copy link
Contributor Author

@bors r=@jieyouxu

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

📌 Commit 4c7f054 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 25, 2025
@workingjubilee
Rollup merge of rust-lang#142844 - dpaoliello:short-ice, r=jieyouxu
25d6fb3 
Enable short-ice for Windows

Works fine for x64 without modifications.

x86 MSVC is still failing.

Addresses item in rust-lang#128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
This was referenced Jun 25, 2025
Closed
Merged
bors added a commit that referenced this pull request Jun 25, 2025
@bors
Auto merge of #142997 - workingjubilee:rollup-6lxec87, r=workingjubilee
a17780d 
Rollup of 15 pull requests

Successful merges:

 - #135731 (Implement parsing of pinned borrows)
 - #138780 (Add `#[loop_match]` for improved DFA codegen)
 - #142453 (Windows: make `read_dir` stop iterating after the first error is encountered)
 - #142633 (Error on invalid signatures for interrupt ABIs)
 - #142768 (Avoid a bitcast FFI call in transmuting)
 - #142825 (Port `#[track_caller]` to the new attribute system)
 - #142844 (Enable short-ice for Windows)
 - #142934 (Tweak `-Zmacro-stats` measurement.)
 - #142955 (Couple of test suite fixes for cg_clif)
 - #142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠)
 - #142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect)
 - #142982 (Corrected spelling mistake in c_str.rs)
 - #142983 (Taint body on invalid call ABI)
 - #142988 (Update wasm-component-ld to 0.5.14)
 - #142993 (Update cargo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4af75b2 into rust-lang:master Jun 25, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 25, 2025
rust-timer added a commit that referenced this pull request Jun 25, 2025
@rust-timer
Unrolled build for #142844
fc0aa74 
Rollup merge of #142844 - dpaoliello:short-ice, r=jieyouxu

Enable short-ice for Windows

Works fine for x64 without modifications.

x86 MSVC is still failing.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dpaoliello @rustbot @Noratrieb @jieyouxu @rust-log-analyzer @bors