Abolish QueryVTable in favour of more assoc items on QueryConfig

[Noratrieb]

This may introduce additional mono but may help const fold things better and especially may help not constructing a QueryVTable anymore which is cheap but not free.

[rustbot]

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

[Noratrieb]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 6a3322f82d418c6636a59cb8a972a79fd7e6ca2c with merge f6adf0eb399990bfcacd1f93ed3fce44ec056328...

[jyn514]

r? @jyn514

[jyn514]

Code looks good to me, I would be very interested to see whether this makes try_load_from_disk_and_cache_in_memory heavier or lighter (that's the third-heaviest function in #65031 (comment)).

[bors]

☀️ Try build successful - checks-actions
Build commit: f6adf0eb399990bfcacd1f93ed3fce44ec056328 (f6adf0eb399990bfcacd1f93ed3fce44ec056328)

[rust-timer]

Finished benchmarking commit (f6adf0eb399990bfcacd1f93ed3fce44ec056328): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.2%, 0.7%]	6
Improvements ✅ (primary)	-0.5%	[-0.8%, -0.2%]	50
Improvements ✅ (secondary)	-0.5%	[-0.9%, -0.1%]	63
All ❌✅ (primary)	-0.5%	[-0.8%, -0.2%]	50

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.4%, 3.2%]	4
Regressions ❌ (secondary)	2.3%	[0.6%, 4.2%]	44
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-5.4%, -5.4%]	1
All ❌✅ (primary)	2.7%	[2.4%, 3.2%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

[jyn514]

apparently this makes rustc_query_impl faster to compile ???

I'm not complaining lol

[jyn514]

r=me with #106307 (comment) fixed :)

[cjgillot]

The compiler got faster. Do you have an idea why? Better optimizations thanks to const propagation?

[Noratrieb]

Probably this and also less time spent assembling a QueryVTable, which isn't expensive but also not free.

[Noratrieb]

@bors r=jyn514

[bors]

📌 Commit ab52170557766931f24274dc76ed5bec38b59122 has been approved by jyn514

It is now in the queue for this repository.

[Noratrieb]

@bors r- i'll address the review feedback first

[Noratrieb]

@rustbot ready

[jyn514]

r? @cjgillot

[cjgillot]

@bors r+

[bors]

📌 Commit 9fe4efe has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9fe4efe with merge d6f99e5...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing d6f99e5 to master...

[rust-timer]

Finished benchmarking commit (d6f99e5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.4%, 1.0%]	4
Improvements ✅ (primary)	-0.5%	[-1.0%, -0.2%]	63
Improvements ✅ (secondary)	-0.6%	[-1.3%, -0.4%]	60
All ❌✅ (primary)	-0.5%	[-1.0%, -0.2%]	63

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.