-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Suggest x build library
for a custom toolchain that fails to load core
#113292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
r? @Nilstrieb |
☔ The latest upstream changes (presumably #113288) made this pull request unmergeable. Please resolve the merge conflicts. |
8c5dd85
to
9b6bdcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally with x test tests/ui
and it passed.
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (aa70e5f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 648.105s -> 647.209s (-0.14%) |
Fixes #113222
The nicer suggestion for dev-channel won't be emitted if
-Z ui-testing
enabled. IMO, this is acceptable for now.