Skip to content

[beta] promote 1.72 #113540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2023
Merged

[beta] promote 1.72 #113540

merged 3 commits into from
Jul 11, 2023

Conversation

Mark-Simulacrum
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 10, 2023
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=50

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

📌 Commit c5aa8fb has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
@bors
Copy link
Collaborator

bors commented Jul 10, 2023

⌛ Testing commit c5aa8fb with merge 50f07ace4bbb853153f2a8630caa116575dd2a8a...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 10, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 10, 2023
@Mark-Simulacrum
Copy link
Member Author

@bors try

I pushed a hack which I think should fix this on beta, but will fail on stable. We'll want to land a proper fix on master and then backport it.

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

⌛ Trying commit 3b84e73bac154704dc321fe13717b0fe1a2ac2b5 with merge ecfef94a8989a254f09275d07dcaca3d7b88a85e...

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

☀️ Try build successful - checks-actions
Build commit: ecfef94a8989a254f09275d07dcaca3d7b88a85e (ecfef94a8989a254f09275d07dcaca3d7b88a85e)

@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 10, 2023

📌 Commit 3b84e73bac154704dc321fe13717b0fe1a2ac2b5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023
@bors
Copy link
Collaborator

bors commented Jul 11, 2023

⌛ Testing commit 3b84e73bac154704dc321fe13717b0fe1a2ac2b5 with merge 4c5b6a27cb52b2214e5025a7079532416243e3ae...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 11, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 11, 2023
@Mark-Simulacrum
Use channel name in artifact -- fixes beta builds
27ff819 
This likely will break on stable promotion because stable artifacts are named with stable version
rather than channel name; we'll want to figure out the right fix for that in a follow-up.
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 11, 2023

📌 Commit 27ff819 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2023
@bors
Copy link
Collaborator

bors commented Jul 11, 2023

⌛ Testing commit 27ff819 with merge 7ba605c...

@bors
Copy link
Collaborator

bors commented Jul 11, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7ba605c to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 11, 2023
@bors bors merged commit 7ba605c into rust-lang:beta Jul 11, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 11, 2023
@Mark-Simulacrum Mark-Simulacrum deleted the beta-backport branch July 11, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @rustbot @bors @rust-log-analyzer