Skip to content

miri: reduce code duplication in some SSE/SSE2 intrinsics #115827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 20, 2023
Merged

miri: reduce code duplication in some SSE/SSE2 intrinsics #115827

merged 9 commits into from
Sep 20, 2023

Conversation

eduardosm
Copy link
Contributor

Reduces code duplication in the Miri implementation of some SSE and SSE2 using generics and rustc_const_eval helper functions.

There are also some other minor changes.

r? @RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 13, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2023

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

RalfJung
RalfJung reviewed Sep 16, 2023
View reviewed changes
RalfJung
RalfJung reviewed Sep 16, 2023
View reviewed changes
RalfJung
RalfJung reviewed Sep 16, 2023
View reviewed changes
@RalfJung
Copy link
Member

LGTM. :) Please squash, then we can land this (if CI is green).

@eduardosm
Copy link
Contributor Author

I squashed the fixups. Would you rather have everything squashed together?

@RalfJung
Copy link
Member

RalfJung commented Sep 16, 2023 •
edited
Loading

No, seems fine, thanks!
r=me after CI passed.
@bors delegate+

@bors
Copy link
Collaborator

bors commented Sep 16, 2023

✌️ @eduardosm, you can now approve this pull request!

If @RalfJung told you to "r=me" after making some further change, please make that change, then do @bors r=@RalfJung

@eduardosm
Copy link
Contributor Author

@bors r=@RalfJung

@bors
Copy link
Collaborator

bors commented Sep 16, 2023

📌 Commit 9fbbfd2 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023
@bors
Copy link
Collaborator

bors commented Sep 20, 2023

⌛ Testing commit 9fbbfd2 with merge 84a9447...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2023
@bors
Auto merge of rust-lang#115827 - eduardosm:miri-sse-reduce-code-dup, …
84a9447 
…r=RalfJung

miri: reduce code duplication in some SSE/SSE2 intrinsics

Reduces code duplication in the Miri implementation of some SSE and SSE2 using generics and rustc_const_eval helper functions.

There are also some other minor changes.

r? `@RalfJung`
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Sep 20, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2023
@RalfJung
Copy link
Member

@bors retry failed to download from https://crates.io/api/v1/crates/env_logger/0.7.1/download

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2023
@bors
Copy link
Collaborator

bors commented Sep 20, 2023

⌛ Testing commit 9fbbfd2 with merge 78e74d9...

@bors
Copy link
Collaborator

bors commented Sep 20, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 78e74d9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2023
@bors bors merged commit 78e74d9 into rust-lang:master Sep 20, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 20, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (78e74d9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.5% [-1.5%, -1.5%] 2
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.622s -> 630.97s (-0.26%)
Artifact size: 317.96 MiB -> 317.89 MiB (-0.02%)

@eduardosm eduardosm deleted the miri-sse-reduce-code-dup branch September 20, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@eduardosm @rustbot @RalfJung @bors @rust-log-analyzer @rust-timer