Skip to content

Fixed iter's is_empty to use is_none() and added relevant test flag #11788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2014
Merged

Fixed iter's is_empty to use is_none() and added relevant test flag #11788

merged 1 commit into from
Jan 25, 2014

Conversation

salemtalha
Copy link
Contributor

Fixes #11785.

@huonw
Copy link
Member

huonw commented Jan 25, 2014

BTW, if you write something like "fixes #11785" in the commit message/description, then GitHub will automatically close that issue when the pull request is merged (I've edited it into the PR description): docs.

@salemtalha
Copy link
Contributor Author

Oh cool! This is my first open source contribution ever, really happy right now.

@huonw
Copy link
Member

huonw commented Jan 25, 2014

Awesome! ❤️

bors added a commit that referenced this pull request Jan 25, 2014
@bors
auto merge of #11788 : salemtalha/rust/master, r=huonw
caabbb8 
Fixes #11785.
@bors bors closed this Jan 25, 2014
@bors bors merged commit 1b4623d into rust-lang:master Jan 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Peekable's is_empty() has the wrong definition.
3 participants
@salemtalha @huonw @bors