Skip to content

Implement Unix domain sockets in libnative #11935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Jan 30, 2014

No description provided.

@Geal
Copy link
Contributor Author

Geal commented Jan 30, 2014

@alexcrichton here it is, rebased and with the fixes you requested

@@ -595,3 +647,306 @@ impl rtio::RtioUdpSocket for UdpSocket {
impl Drop for UdpSocket {
fn drop(&mut self) { unsafe { close(self.fd) } }
}


#[cfg(not(windows))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can get removed.

@Geal
Copy link
Contributor Author

Geal commented Jan 30, 2014

haha, there's still a lot to fix. I'll get through it :)

@alexcrichton
Copy link
Member

If you're running short on time, I'm more than willing to take this over. I'd love to get this merged!

@Geal
Copy link
Contributor Author

Geal commented Feb 4, 2014

I'm currently on vacation and will not have much time until the 18th. I'll
put on this PR what I already fixed following your suggestions, then you
can take over.
Le 4 févr. 2014 00:30, "Alex Crichton" [email protected] a écrit :

If you're running short on time, I'm more than willing to take this over.
I'd love to get this merged!


Reply to this email directly or view it on GitHubhttps://github.com//pull/11935#issuecomment-34013731
.

@alexcrichton
Copy link
Member

Sounds good to me, and certainly no rush! I'd rather you enjoy your vacation than update this PR :)

@alexcrichton
Copy link
Member

I'll take over from here, thanks again for this!

flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 7, 2024
The lint makes sure that the map is not used (borrowed) before the call
to `insert`. Since the lint creates a mutable borrow on the map with the
`Entry`, it wouldn't be possible to replace such code with `Entry`.
However, expressions up to the `insert` call are checked, but not
expressions for the arguments of the `insert` call itself. This commit
fixes that.

Fixes rust-lang#11935
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 7, 2024
[`map_entry`]: Check insert expression for map use

The lint makes sure that the map is not used (borrowed) before the call to `insert`. Since the lint creates a mutable borrow on the map with the `Entry`, it wouldn't be possible to replace such code with `Entry`. However, expressions up to the `insert` call are checked, but not expressions for the arguments of the `insert` call itself. This commit fixes that.

Fixes rust-lang#11935

----

changelog: [`map_entry`]: Fix false positive when borrowing the map in the `insert` call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants