-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Implement Unix domain sockets in libnative #11935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alexcrichton here it is, rebased and with the fixes you requested |
@@ -595,3 +647,306 @@ impl rtio::RtioUdpSocket for UdpSocket { | |||
impl Drop for UdpSocket { | |||
fn drop(&mut self) { unsafe { close(self.fd) } } | |||
} | |||
|
|||
|
|||
#[cfg(not(windows))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can get removed.
haha, there's still a lot to fix. I'll get through it :) |
If you're running short on time, I'm more than willing to take this over. I'd love to get this merged! |
I'm currently on vacation and will not have much time until the 18th. I'll
|
Sounds good to me, and certainly no rush! I'd rather you enjoy your vacation than update this PR :) |
I'll take over from here, thanks again for this! |
The lint makes sure that the map is not used (borrowed) before the call to `insert`. Since the lint creates a mutable borrow on the map with the `Entry`, it wouldn't be possible to replace such code with `Entry`. However, expressions up to the `insert` call are checked, but not expressions for the arguments of the `insert` call itself. This commit fixes that. Fixes rust-lang#11935
[`map_entry`]: Check insert expression for map use The lint makes sure that the map is not used (borrowed) before the call to `insert`. Since the lint creates a mutable borrow on the map with the `Entry`, it wouldn't be possible to replace such code with `Entry`. However, expressions up to the `insert` call are checked, but not expressions for the arguments of the `insert` call itself. This commit fixes that. Fixes rust-lang#11935 ---- changelog: [`map_entry`]: Fix false positive when borrowing the map in the `insert` call
No description provided.