Don't copy arguments passed by value with indirection to allocas. #12014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please back this change up with the output of |
|
This change should be OK. I am wary of making trans less readable in the name of cleaner output, but this is a pretty minor diff. |
| if type_of::arg_is_indirect(bcx.ccx(), arg_ty) { | ||
| // Don't copy an indirect argument to an alloca, the caller | ||
| // already put it in a temporary alloca and gave it up. | ||
| bcx.fcx.schedule_drop_mem(arg_scope, arg.val, arg_ty); |
There was a problem hiding this comment.
Not that it matters, but you could write: let arg_val = arg.add_clean(arg_scope); and then use arg_val below. That's how the datum class is intended to be used (i.e., more like a linear value -- it should always get consumed)
|
(r+ with that nit corrected) |
bors
added a commit
that referenced
this pull request
Feb 5, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
feat: Attempt to format expand_macro output with rustfmt if possible Fixes rust-lang/rust-analyzer#10548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.