Skip to content

RustWrapper: adapt for llvm/llvm-project@a38152e2156 #120996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Feb 13, 2024

I am only partially confident this is reasonable, and the argument is ignored on targets other than ARM64EC which appears to be some Windows 11 thing, and therefore I have no way to test.

@rustbot label: +llvm-main

I am only partially confident this is reasonable, and the argument is
ignored on targets other than ARM64EC which appears to be some Windows
11 thing, and therefore I have no way to test.

@rustbot label: +llvm-main
@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Feb 13, 2024
@cuviper
Copy link
Member

cuviper commented Feb 13, 2024

@wesleywiser perhaps you (or someone you know) could evaluate this Windows change?

@cjacek
Copy link

cjacek commented Feb 13, 2024

Non-hybrid targets should not use it to pass exports to writeImportLibrary, please use something like std::nullopt instead. I created llvm/llvm-project#81600 to clarify that.

@durin42
Copy link
Contributor Author

durin42 commented Feb 13, 2024

Done, thanks!

@durin42
Copy link
Contributor Author

durin42 commented Feb 13, 2024

The argument is now optional, so this shouldn't be needed. I'll open a new PR if we end up needing a change here.

@durin42 durin42 closed this Feb 13, 2024
@durin42 durin42 deleted the llvm-19-writeImportLibrary branch April 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants