Fix sending/try_recv on channels from off the runtime #12397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me with fixes (last one optional) |
|
(Would it be possible/reasonable to support non-blocking recieves off the runtime too?) |
|
I believe it is indeed reasonable! Updated commit/PR description as well |
| @@ -521,12 +521,13 @@ impl<T: Send> Port<T> { | |||
| pub fn try_recv(&self) -> TryRecvResult<T> { | |||
| // If a thread is spinning in try_recv, we should take the opportunity | |||
| // to reschedule things occasionally. See notes above in scheduling on | |||
| // sends for why this doesn't always hit TLS. | |||
| // sends for why this doesn't always hit TLS, and also for why this uses | |||
| // `try_take` instead of `take`. | |||
There was a problem hiding this comment.
Oops, thanks! I've added one.
The fairness yield mistakenly called `Local::take()` which meant that it would only work if a local task was available. In theory sending on a channel (or calling try_recv) requires no runtime because it never blocks, so there's no reason it shouldn't support such a use case. Closes rust-lang#12391
bors
added a commit
that referenced
this pull request
Feb 20, 2014
The fairness yield mistakenly called `Local::take()` which meant that it would only work if a local task was available. In theory sending on a channel (or calling try_recv) requires no runtime because it never blocks, so there's no reason it shouldn't support such a use case. Closes #12391
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fairness yield mistakenly called
Local::take()which meant that it wouldonly work if a local task was available. In theory sending on a channel (or calling try_recv) requires
no runtime because it never blocks, so there's no reason it shouldn't support
such a use case.
Closes #12391