clean up some transmutes #13007
Closed
clean up some transmutes #13007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -401,12 +401,10 @@ pub mod reader { | |||
| } | |||
|
|
|||
| fn read_f64(&mut self) -> f64 { | |||
| let bits = doc_as_u64(self.next_doc(EsF64)); | |||
| unsafe { transmute(bits) } | |||
| doc_as_u64(self.next_doc(EsF64)) as f64 | |||
There was a problem hiding this comment.
This isn't quite accurate because u64 as f64 is a floating-point-cast, whereas transmute is just a bit-cast
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 16, 2022
Use Node 16 on CI and upgrade lockfile version Code is on 16 too, there's hopefully no need to keep using the old version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.