Remove ~[] from librand, rename Rng.shuffle_mut to .shuffle #13177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This has got some minor problems where I forgot to update the testsuite; I don't have time to fix it now, but a review would still be appreciated, since fixing those problems is just adjusting the various type hints.) |
|
You should just remove |
|
I agree with @kballard |
|
@kballard |
huonw
changed the title
|
Updated with the suggested |
|
r=me with my comment |
There are a few instances of them in tests which are using functions from std etc. that still are using ~[].
Deprecates the `shuffle_mut` name in favour of `shuffle` too. In future there will be many different types of owned vectors/vector-likes (e.g. DST's ~[], Vec, SmallVec, Rope, ...), and so privileging just `Vec` with the "functional" `shuffle` method is silly.
bors
added a commit
that referenced
this pull request
Apr 2, 2014
Remove ~[] from librand, rename Rng.shuffle_mut to .shuffle. See commits.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 8, 2024
…config, r=xFrednet Fix broken list for lints config Follow-up of rust-lang#13166. Finally figured out that it was a transformation and not the source that was the problem. It now looks like this:  r? `@xFrednet` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ~[] from librand, rename Rng.shuffle_mut to .shuffle.
See commits.