Remove wasm legacy abi #133952

bjorn3 · 2024-12-06T09:17:59Z

Closes #122532
Closes #138762
Fixes #71871
Fixes #88152
Fixes #115666
Fixes #129486

rustbot · 2024-12-06T09:18:07Z

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-12-06T09:18:09Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

rustbot · 2024-12-06T09:46:52Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

f456ebf

daxpedda · 2024-12-16T07:05:10Z

#129630 needs to be reverted or adjusted as well.

bjorn3 · 2024-12-16T11:23:09Z

Removed the section in question.

RalfJung · 2025-01-08T18:27:47Z

compiler/rustc_ty_utils/src/abi.rs

-
-                        match spec_abi {
-                            ExternAbi::Unadjusted => {}
-                            ExternAbi::PtxKernel => {}


Is the PtxKernel exception not needed any more?

To avoid conflicts I based this PR on #133932 which is the PR for making extern "ptx-kernel" have the right abi.

bors · 2025-02-06T00:51:31Z

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-02-07T17:02:24Z

☔ The latest upstream changes (presumably #136684) made this pull request unmergeable. Please resolve the merge conflicts.

…lexcrichton Remove wasm legacy abi Closes rust-lang#122532 Closes rust-lang#138762 Fixes rust-lang#71871 rust-lang#88152 Fixes rust-lang#115666 Fixes rust-lang#129486

Rollup of 10 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #134661 (Reduce precedence of expressions that have an outer attr) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141864 (Handle win32 separator for cygwin paths) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142377 (Try unremapping compiler sources) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142509 (bump std libc dependency) r? `@ghost` `@rustbot` modify labels: rollup

…lexcrichton Remove wasm legacy abi Closes rust-lang#122532 Closes rust-lang#138762 Fixes rust-lang#71871 rust-lang#88152 Fixes rust-lang#115666 Fixes rust-lang#129486

Rollup of 9 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141864 (Handle win32 separator for cygwin paths) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142377 (Try unremapping compiler sources) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142509 (bump std libc dependency) r? `@ghost` `@rustbot` modify labels: rollup

…lexcrichton Remove wasm legacy abi Closes rust-lang#122532 Closes rust-lang#138762 Fixes rust-lang#71871 rust-lang#88152 Fixes rust-lang#115666 Fixes rust-lang#129486

Rollup of 8 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141864 (Handle win32 separator for cygwin paths) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142509 (bump std libc dependency) r? `@ghost` `@rustbot` modify labels: rollup

…lexcrichton Remove wasm legacy abi Closes rust-lang#122532 Closes rust-lang#138762 Fixes rust-lang#71871 rust-lang#88152 Fixes rust-lang#115666 Fixes rust-lang#129486

Rollup of 9 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #134661 (Reduce precedence of expressions that have an outer attr) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141864 (Handle win32 separator for cygwin paths) - #141937 (Report never type lints in dependencies) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #134661 (Reduce precedence of expressions that have an outer attr) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141937 (Report never type lints in dependencies) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142499 (Remove check run bootstrap) - #142543 (Suggest adding semicolon in user code rather than macro impl details) r? `@ghost` `@rustbot` modify labels: rollup

RalfJung · 2025-06-16T01:57:05Z

compiler/rustc_codegen_ssa/src/mir/naked_asm.rs

-    // FIXME: remove this once the wasm32-unknown-unknown ABI is fixed
-    // please also add `wasm32-unknown-unknown` back in `tests/assembly/wasm32-naked-fn.rs`
-    // basically the commit introducing this comment should be reverted


The comment asks to add the target back in a test file -- which the PR does not seem to do? The test file seems to have been renamed to tests/assembly/naked-functions/wasm32.rs.

Opened #142565

Rollup merge of #133952 - bjorn3:remove_wasm_legacy_abi, r=alexcrichton Remove wasm legacy abi Closes #122532 Closes #138762 Fixes #71871 #88152 Fixes #115666 Fixes #129486

…st, r=RalfJung Test naked asm for wasm32-unknown-unknown cc rust-lang#133952 (comment)

Rollup merge of #142565 - bjorn3:wasm32_unknown_naked_asm_test, r=RalfJung Test naked asm for wasm32-unknown-unknown cc #133952 (comment)

Manishearth · 2025-06-17T16:12:04Z

No, this is not the plan we agreed upon.

This changes the default at the same time it removes the flag. This is not something that can be easily switched over to for code that needs to test/run on multiple Rust versions.

There was an explicit plan in #122532 (comment), and it seemed to be what everyone coalesced around:

If you're ok with that, that seems like a reasonable plan to move forward to me, with a possible schedule looking like:

Land FCW + write blog post.

Wait for FCW to hit stable

Change -Zwasm-c-abi default in nightly once FCW is on stable

Wait for new default to hit stable

Remove FCW + -Zwasm-c-abi

Admittedly, this is slightly different from what is in the blog post, which makes no claims about when the default will switch over. I should have noticed that oversight, my bad.

The current change puts us in a situation where we cannot write code that targets multiple versions at once. This is a crucial stage in managing transitions: you start with code that only works with the old thing, and then you move to code that works with both the old and new thing, and you finally end up with code that only works with the new thing.

Personally speaking I don't need the legacy ABI to be maintained as a flag: it is sufficient for the -Zwasm-c-abi flag to become a singleton flag that is a no-op.

We might have workarounds for this, but it's somewhat frustrating that this is still being handled in a hard-to-transition way after tedious discussions about trying not to do that.

bjorn3 · 2025-06-17T16:39:40Z

There was an explicit plan in #122532 (comment), and it seemed to be what everyone coalesced around:

I didn't remember that comment when I responsed to Alex's question about the status of this PR: #133952 (comment) My bad.

Personally speaking I don't need the legacy ABI to be maintained as a flag: it is sufficient for the -Zwasm-c-abi flag to become a singleton flag that is a no-op.

I can make a PR to add back a no-op -Zwasm-c-abi flag with spec as only allowed value. Does that work for you?

Manishearth · 2025-06-17T17:00:39Z

@bjorn3 Yep, it works for me! Still needs some work on my side but it smooths things out and at this point I don't want to drag this out further :)

alexcrichton · 2025-06-17T19:21:58Z

That's my bad as well, apologies for forgetting that!

but it's somewhat frustrating that this is still being handled in a hard-to-transition way after tedious discussions about trying not to do that.

Sorry for the frustration, but don't forget that this issue has spanned many contributors, years, and possible shapes of solutions. It's tough to keep track of things sometimes. Nevertheless thanks @bjorn3 for quickly making #142635!

Manishearth · 2025-06-17T20:04:55Z

@alexcrichton Yes, I am aware, but it's a bit of a "fool me once" situation: this is not the first time this type of breakage has happened, and seeing it happen twice on the same issue after stakeholders have been pulled in is super disheartening. I don't blame individuals for this, but I do think the compiler team might need to improve its processes here. Designing and following principled transition plans has been a failing of the Rust project for ages: the first edition ended up being a lot more work because we found out in the last minute that nobody had actually designed transition plans. It's a repeated problem.

Of course things are tough to keep track of; but we have special carve outs in the process to keep track of things we consider a priority. Transition plans probably should be a priority since they directly affect Rust users and affect Rust's reputation¹.

When these things happen I have occasionally had to convince other people I work with to not make a big Thing out of it, but it's harder to do so as it starts to be a pattern. Like, I'm not trying to be difficult here, it's just that the more this happens the less I can do to help Rust's reputation here. ↩

bjorn3 added O-wasm Target: WASM (WebAssembly), http://webassembly.org/ A-ABI Area: Concerning the application binary interface (ABI) labels Dec 6, 2024

rustbot assigned cjgillot Dec 6, 2024

bjorn3 added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2024

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2024

bjorn3 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2024

workingjubilee mentioned this pull request Dec 6, 2024

Make the wasm_c_abi future compat warning a hard error #133951

Merged

workingjubilee assigned alexcrichton and workingjubilee and unassigned cjgillot Dec 6, 2024

bjorn3 force-pushed the remove_wasm_legacy_abi branch from 88f79ac to 26c9b6e Compare December 6, 2024 09:46

bjorn3 marked this pull request as draft December 6, 2024 09:48

bjorn3 force-pushed the remove_wasm_legacy_abi branch from 26c9b6e to 16e660d Compare December 6, 2024 13:42

bjorn3 mentioned this pull request Dec 16, 2024

Status of rust+C bindings for wasm targets rustwasm/team#291

Open

RalfJung reviewed Jan 8, 2025

View reviewed changes

bjorn3 mentioned this pull request Jan 17, 2025

support wasm inline assembly in naked_asm! #135648

Merged

bjorn3 force-pushed the remove_wasm_legacy_abi branch from 6970f8d to e4c01de Compare January 26, 2025 14:21

bjorn3 force-pushed the remove_wasm_legacy_abi branch from e4c01de to e91711c Compare February 6, 2025 10:07

bjorn3 removed the has-merge-commits PR has merge commits, merge with caution. label Feb 21, 2025

bjorn3 force-pushed the remove_wasm_legacy_abi branch from e91711c to 106301d Compare February 28, 2025 09:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 14, 2025

fmease mentioned this pull request Jun 14, 2025

Rollup of 10 pull requests #142522

Closed

matthiaskrgr mentioned this pull request Jun 15, 2025

Rollup of 9 pull requests #142533

Closed

matthiaskrgr mentioned this pull request Jun 15, 2025

Rollup of 8 pull requests #142535

Closed

fmease mentioned this pull request Jun 15, 2025

Rollup of 9 pull requests #142545

Closed

fmease mentioned this pull request Jun 15, 2025

Rollup of 10 pull requests #142550

Merged

RalfJung reviewed Jun 16, 2025

View reviewed changes

bors merged commit d6dc965 into rust-lang:master Jun 16, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 16, 2025

rust-timer added a commit that referenced this pull request Jun 16, 2025

Unrolled build for #133952

6c0e0a2

Rollup merge of #133952 - bjorn3:remove_wasm_legacy_abi, r=alexcrichton Remove wasm legacy abi Closes #122532 Closes #138762 Fixes #71871 #88152 Fixes #115666 Fixes #129486

bjorn3 deleted the remove_wasm_legacy_abi branch June 16, 2025 08:02

bjorn3 mentioned this pull request Jun 16, 2025

Test naked asm for wasm32-unknown-unknown #142565

Merged

Kobzol added a commit to Kobzol/rust that referenced this pull request Jun 16, 2025

Rollup merge of rust-lang#142565 - bjorn3:wasm32_unknown_naked_asm_te…

a53c1d7

…st, r=RalfJung Test naked asm for wasm32-unknown-unknown cc rust-lang#133952 (comment)

rust-timer added a commit that referenced this pull request Jun 16, 2025

Unrolled build for #142565

c4b11c7

Rollup merge of #142565 - bjorn3:wasm32_unknown_naked_asm_test, r=RalfJung Test naked asm for wasm32-unknown-unknown cc #133952 (comment)

bjorn3 mentioned this pull request Jun 17, 2025

Temporarily add back -Zwasm-c-abi=spec #142635

Open

Remove wasm legacy abi #133952

Remove wasm legacy abi #133952

Conversation

bjorn3 commented Dec 6, 2024 • edited by RalfJung Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 6, 2024

Uh oh!

rustbot commented Dec 6, 2024

Uh oh!

rustbot commented Dec 6, 2024

Uh oh!

daxpedda commented Dec 16, 2024

Uh oh!

bjorn3 commented Dec 16, 2024

Uh oh!

RalfJung Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

bjorn3 Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

bors commented Feb 6, 2025

Uh oh!

bors commented Feb 7, 2025

Uh oh!

RalfJung Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

bjorn3 Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Manishearth commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjorn3 commented Jun 17, 2025

Uh oh!

Manishearth commented Jun 17, 2025

Uh oh!

alexcrichton commented Jun 17, 2025

Uh oh!

Manishearth commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

Uh oh!

bjorn3 commented Dec 6, 2024 •

edited by RalfJung

Loading

Manishearth commented Jun 17, 2025 •

edited

Loading

Manishearth commented Jun 17, 2025 •

edited

Loading