librustc: Remove ~EXPR, ~TYPE, and ~PAT from the language, except
#13958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mechanical changes seem fine to me, two questions I have:
|
|
Waiting a long time for discussion on something that is already agreed on is going to do nothing other than cause this PR to bitrot. This does not add support for |
|
I'm not saying we should wait a long time, just till tomorrow to discuss whether |
|
I guess that's fine. |
|
Ah, almost forgot, this commit message should be worded in accordance with our new breaking changes policy. |
for `~str`/`~[]`. Note that `~self` still remains, since I forgot to add support for `Box<self>` before the snapshot. How to update your code: * Instead of `~EXPR`, you should write `box EXPR`. * Instead of `~TYPE`, you should write `Box<Type>`. * Instead of `~PATTERN`, you should write `box PATTERN`. [breaking-change]
bors
added a commit
that referenced
this pull request
May 7, 2014
for `~str`/`~[]`. Note that `~self` still remains, since I forgot to add support for `Box<self>` before the snapshot. r? @brson or @alexcrichton or whoever
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
`define_clippy_lints` does not exist, `declare_clippy_lint` exists. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
~str/~[].Note that
~selfstill remains, since I forgot to add support forBox<self>before the snapshot.r? @brson or @alexcrichton or whoever