-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Optimize Rust Analyzer with BOLT #139648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Rust Analyzer with BOLT #139648
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Optimize Rust Analyzer with BOLT Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try. r? `@ghost`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
@bors try |
Optimize Rust Analyzer with BOLT Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try. r? `@ghost` try-job: dist-x86_64-linux
Finished benchmarking commit (300be8e): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 783.243s -> 783.771s (0.07%) |
☀️ Try build successful - checks-actions |
@bors try |
Optimize Rust Analyzer with BOLT Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try. r? `@ghost` try-job: dist-x86_64-linux
☀️ Try build successful - checks-actions |
@bors try |
Optimize Rust Analyzer with BOLT Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try. r? `@ghost` try-job: dist-x86_64-linux
☀️ Try build successful - checks-actions |
@bors try |
Optimize Rust Analyzer with BOLT Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try. r? `@ghost` try-job: dist-x86_64-linux
☔ The latest upstream changes (presumably #139588) made this pull request unmergeable. Please resolve the merge conflicts. |
☀️ Try build successful - checks-actions |
Looks like BOLT provides a 5% performance boost without PGO. Maybe starting with PGO would be better. |
BOLT doesn't seem to be worth it for RA performance-wise. However, PGO does have a great effect (rust-lang/rust-analyzer#19595, up to 20%), so we should do that instead. |
Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try.
r? @ghost
try-job: dist-x86_64-linux