Skip to content

Optimize Rust Analyzer with BOLT #139648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 10, 2025

Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try.

r? @ghost

try-job: dist-x86_64-linux

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 10, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 10, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2025
Optimize Rust Analyzer with BOLT

Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Apr 10, 2025

⌛ Trying commit 925fdb1 with merge 300be8e...

@bors
Copy link
Collaborator

bors commented Apr 10, 2025

☀️ Try build successful - checks-actions
Build commit: 300be8e (300be8ebbb2c84b13cb0e70bdba848a9101038fc)

@rust-timer

This comment has been minimized.

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 11, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Optimize Rust Analyzer with BOLT

Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try.

r? `@ghost`

try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Apr 11, 2025

⌛ Trying commit 925fdb1 with merge 39d181d...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (300be8e): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 1

Cycles

Results (secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 783.243s -> 783.771s (0.07%)
Artifact size: 366.21 MiB -> 366.18 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 11, 2025
@bors
Copy link
Collaborator

bors commented Apr 11, 2025

☀️ Try build successful - checks-actions
Build commit: 39d181d (39d181d7a76ec618eb9f568c2c8561c90a71ad46)

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 11, 2025

@bors try

@bors
Copy link
Collaborator

bors commented Apr 11, 2025

⌛ Trying commit d33c8f6 with merge 2f10bd1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Optimize Rust Analyzer with BOLT

Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try.

r? `@ghost`

try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Apr 11, 2025

☀️ Try build successful - checks-actions
Build commit: 2f10bd1 (2f10bd1d92dbc58d106de1be7a3578c763f42227)

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 11, 2025

@bors try

@bors
Copy link
Collaborator

bors commented Apr 11, 2025

⌛ Trying commit 9d5d925 with merge 82c2bcf...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Optimize Rust Analyzer with BOLT

Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try.

r? `@ghost`

try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Apr 11, 2025

☀️ Try build successful - checks-actions
Build commit: 82c2bcf (82c2bcf046174357289b51920a640c3dc171ba03)

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 11, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Optimize Rust Analyzer with BOLT

Funnily enough, it is easier to use BOLT for another component than to do PGO (at least I think so..). Let's try.

r? `@ghost`

try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Apr 11, 2025

⌛ Trying commit b6af0a6 with merge a697a80...

@bors
Copy link
Collaborator

bors commented Apr 11, 2025

☔ The latest upstream changes (presumably #139588) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Apr 11, 2025

☀️ Try build successful - checks-actions
Build commit: a697a80 (a697a80df2caed580c71e9c6eb2e3fddc5b4d44c)

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 12, 2025

Looks like BOLT provides a 5% performance boost without PGO. Maybe starting with PGO would be better.

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 16, 2025

BOLT doesn't seem to be worth it for RA performance-wise. However, PGO does have a great effect (rust-lang/rust-analyzer#19595, up to 20%), so we should do that instead.

@Kobzol Kobzol closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants