Rollup of 3 pull requests #140070

ChrisDenton · 2025-04-20T10:10:09Z

Successful merges:

transmutability: remove NFA intermediate representation #139990 (transmutability: remove NFA intermediate representation)
rustc-dev-guide subtree update #140044 (rustc-dev-guide subtree update)
Switch exploit mitigations to mdbook footnotes #140051 (Switch exploit mitigations to mdbook footnotes)

r? @ghost
@rustbot modify labels: rollup

Fix link to rustc_* TEST attributes in ui.md

1. added two new parts: Bootstrapping and Supporting Infrastructure; 2. touched up names of pre-existing parts, to match actual names in sidebar; 3. syntactic nits (start description of Analysis with a capital letter); and 4. make numbered list use only 1. Co-authored-by: Tshepang Mbambo <[email protected]>

Update table of contents in about-this-guide.md

Update "crater" link to actually point to crater.md

ease copy-paste

Not obvious what "sort by" means

"how much to trust" implies the opposite

add missing word

date-check rdg contribution section

fix path

Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot.toml

- use correct code block markers - add missing title - rustfmt can now use edition setting in its config ... and this is set in Rust repo - reduce visual noise - needless repetition - convention is to start sentence with upper case - sembr - whitespace - semi-heading not adding much value - fix grammar

…aning Coding conventions chapter cleaning

Signed-off-by: xizheyin <[email protected]>

Remind to update dev branch while behind too many commits

readme: be copy-paste friendly

Rustc pull update

…encies

This updates the exploit mitigations chapter in the rustc book to use the footnote feature of mdbook instead of manually implementing footnotes with HTML.

Prior to this commit, the transmutability analysis used an intermediate NFA representation of type layout. We then determinized this representation into a DFA, upon which we ran the core transmutability analysis. Unfortunately, determinizing NFAs is expensive. In this commit, we avoid NFAs entirely by observing that Rust `union`s are the only source of nondeterminism and that it is comparatively cheap to compute the DFA union of DFAs. We also implement Graphviz DOT debug formatting of DFAs. Fixes rust-lang/project-safe-transmute#23 Fixes rust-lang/project-safe-transmute#24

transmutability: remove NFA intermediate representation Prior to this commit, the transmutability analysis used an intermediate NFA representation of type layout. We then determinized this representation into a DFA, upon which we ran the core transmutability analysis. Unfortunately, determinizing NFAs is expensive. In this commit, we avoid NFAs entirely by observing that Rust `union`s are the only source of nondeterminism and that it is comparatively cheap to compute the DFA union of DFAs. We also implement Graphviz DOT debug formatting of DFAs. Fixes rust-lang/project-safe-transmute#23 Fixes rust-lang/project-safe-transmute#24 r? `@compiler-errors`

rustc-dev-guide subtree update r? `@ghost`

Switch exploit mitigations to mdbook footnotes This updates the exploit mitigations chapter in the rustc book to use the footnote feature of mdbook instead of manually implementing footnotes with HTML.

ChrisDenton · 2025-04-20T10:11:16Z

@bors r+ rollup=never p=5

bors · 2025-04-20T10:11:19Z

📌 Commit d52db51 has been approved by ChrisDenton

It is now in the queue for this repository.

bors · 2025-04-20T10:53:00Z

⌛ Testing commit d52db51 with merge b1c1830...

…enton Rollup of 3 pull requests Successful merges: - rust-lang#139990 (transmutability: remove NFA intermediate representation) - rust-lang#140044 (rustc-dev-guide subtree update) - rust-lang#140051 (Switch exploit mitigations to mdbook footnotes) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-04-20T12:59:55Z

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling coretests v0.0.0 (D:\a\rust\rust\library\coretests)
[RUSTC-TIMING] alloctests test:false 0.099
[RUSTC-TIMING] sysroot test:false 0.048
   Compiling sysroot v0.0.0 (D:\a\rust\rust\library\sysroot)
error: failed to build archive at `D:\a\rust\rust\build\i686-pc-windows-msvc\stage1-std\i686-pc-windows-msvc\release\deps\libcoretests-400fdc9a79f80699.rlib`: couldn't create a directory for the temp file: Access is denied. (os error 5) at path "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage1-std\\i686-pc-windows-msvc\\release\\deps\\.tmpR6whDr.temp-archive"

[RUSTC-TIMING] coretests test:false 0.132
error: could not compile `coretests` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] sysroot test:true 0.375
[RUSTC-TIMING] build_script_build test:false 0.520
[RUSTC-TIMING] rand_core test:false 0.634
Build completed unsuccessfully in 1:58:03
make: *** [Makefile:113: ci-msvc-py] Error 1
  local time: Sun Apr 20 12:59:40 CUT 2025
  network time: Sun, 20 Apr 2025 12:59:41 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-04-20T13:00:29Z

💔 Test failed - checks-actions

ChrisDenton · 2025-04-20T13:03:46Z

spurious fail but I'll do a new rollup with a few more PRs

smanilov and others added 30 commits April 11, 2025 12:12

Fix link to rustc_* TEST attributes in ui.md

c285fe7

Merge pull request rust-lang#2324 from smanilov/patch-3

5806cb5

Fix link to rustc_* TEST attributes in ui.md

Merge pull request rust-lang#2320 from smanilov/patch-1

e6eb98f

Update table of contents in about-this-guide.md

Update "crater" link to actually point to crater.md

c5e2369

Merge pull request rust-lang#2325 from freyacodes/crater-link-fix

46df457

Update "crater" link to actually point to crater.md

ease copy-paste

e0a2250

Merge pull request rust-lang#2326 from rust-lang/tshepang-patch-3

1a20e21

ease copy-paste

use more simple language

3ae1c9d

Not obvious what "sort by" means

remove implied text

770a6fc

"how much to trust" implies the opposite

add missing word

7ba53b7

Merge pull request rust-lang#2328 from rust-lang/tshepang-patch-3

af4419a

Merge pull request rust-lang#2329 from rust-lang/tshepang-patch-4

208e421

add missing word

Merge pull request rust-lang#2327 from rust-lang/tshepang-patch-1

14ea903

date-check rdg contribution section

e33a6d6

Merge pull request rust-lang#2330 from rust-lang/tshepang-patch-5

f79a89d

date-check rdg contribution section

fix path

667aa2e

Merge pull request rust-lang#2331 from rust-lang/tshepang-patch-6

17f72ff

fix path

use consistent title capitalization

2af7ec3

Enable [canonicalize-issue-links] and [no-mentions] in triagebot.toml

40bfc14

Merge pull request rust-lang#2335 from Urgau/triagebot-feat-1

de1dfd3

Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot.toml

tests: document -A {unused,internal_features} ui test mode presets

8c378f7

Merge pull request rust-lang#2321 from jieyouxu/ui-lint-allows

38f06e3

Merge pull request rust-lang#2334 from rust-lang/consistency

b3b89b6

Merge pull request rust-lang#2333 from rust-lang/convetions-chapt-cle…

97be6a6

…aning Coding conventions chapter cleaning

Remind to update dev branch while behind too many commits

855ecf9

Signed-off-by: xizheyin <[email protected]>

Merge pull request rust-lang#2337 from xizheyin/sync-code

a9bcdb0

Remind to update dev branch while behind too many commits

add a first version of autodiff docs

1236dcb

Merge pull request rust-lang#2339 from rust-lang/autodiff-docs

35a3c3b

tshepang and others added 12 commits April 19, 2025 13:09

Merge pull request rust-lang#2344 from rust-lang/tshepang-patch-1

52616fa

readme: be copy-paste friendly

Preparing for merge from rustc

a0c64dc

Merge from rustc

3b2302e

fix broken link

07b7f00

Merge pull request rust-lang#2347 from rust-lang/rustc-pull

b886a8e

Rustc pull update

document #[cfg(bootstrap)] in dependencies

1ab497b

Merge pull request rust-lang#2346 from folkertdev/bootstrap-in-depend…

976d13f

…encies

Switch exploit mitigations to mdbook footnotes

f3b7e23

This updates the exploit mitigations chapter in the rustc book to use the footnote feature of mdbook instead of manually implementing footnotes with HTML.

Rollup merge of rust-lang#140044 - tshepang:rdg-push, r=jieyouxu

6b58d31

rustc-dev-guide subtree update r? `@ghost`

Rollup merge of rust-lang#140051 - ehuss:exploit-footnotes, r=jieyouxu

d52db51

Switch exploit mitigations to mdbook footnotes This updates the exploit mitigations chapter in the rustc book to use the footnote feature of mdbook instead of manually implementing footnotes with HTML.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2025

ChrisDenton closed this Apr 20, 2025

ChrisDenton deleted the rollup-q1g97rc branch April 20, 2025 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 3 pull requests #140070

Rollup of 3 pull requests #140070

Uh oh!

ChrisDenton commented Apr 20, 2025

Uh oh!

ChrisDenton commented Apr 20, 2025

Uh oh!

bors commented Apr 20, 2025

Uh oh!

bors commented Apr 20, 2025

Uh oh!

rust-log-analyzer commented Apr 20, 2025

Uh oh!

bors commented Apr 20, 2025

Uh oh!

ChrisDenton commented Apr 20, 2025

Uh oh!

Uh oh!

Rollup of 3 pull requests #140070

Rollup of 3 pull requests #140070

Uh oh!

Conversation

ChrisDenton commented Apr 20, 2025

Uh oh!

ChrisDenton commented Apr 20, 2025

Uh oh!

bors commented Apr 20, 2025

Uh oh!

bors commented Apr 20, 2025

Uh oh!

rust-log-analyzer commented Apr 20, 2025

Uh oh!

bors commented Apr 20, 2025

Uh oh!

ChrisDenton commented Apr 20, 2025

Uh oh!

Uh oh!