-
Notifications
You must be signed in to change notification settings - Fork 13.4k
tools-aux ci runner: also cross-test doctests in Miri #141210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @albertlarsan68. Use |
$(Q)MIRIFLAGS="-Zmiri-disable-isolation" \ | ||
$(BOOTSTRAP) miri --stage 2 library/std \ | ||
$(BOOTSTRAP_ARGS) \ | ||
--doc -- \ | ||
--skip fs:: --skip net:: --skip process:: --skip sys::fd:: --skip sys::pal:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why I have split up this call into separate --no-doc
and --doc
invocations... we'll see if anything breaks I guess.^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have done it to get separate timings. It doesn't seem worth keeping that.
@bors try |
tools-aux ci runner: also cross-test doctests in Miri Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc. try-job: x86_64-gnu-aux
73fcdf6
to
721fb52
Compare
@bors try |
tools-aux ci runner: also cross-test doctests in Miri Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc. try-job: x86_64-gnu-aux
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
721fb52
to
6eb1afa
Compare
@bors try |
tools-aux ci runner: also cross-test doctests in Miri Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc. try-job: x86_64-gnu-aux
☀️ Try build successful - checks-actions |
While we're at it I also enabled strict provenance enforcement for some of the tests -- we probably don't want to have int2ptr casts in the standard library. (miri-test-libstd already tests with that flag.) @bors try |
tools-aux ci runner: also cross-test doctests in Miri Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc. try-job: x86_64-gnu-aux
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
8b7b026
to
b9e6995
Compare
@bors try |
tools-aux ci runner: also cross-test doctests in Miri Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc. try-job: x86_64-gnu-aux
☀️ Try build successful - checks-actions |
Oh, the labels are outdated. |
@rust-lang/miri this only takes a few extra minutes since doctests are executed in parallel by rustdoc -- so maybe we can land this without waiting for an infra review? |
I was thinking of approving this based on your description, but I'm surprised to see edits to this file in particular. I've never touched it before, and I don't know how it integrates with our CI. So I'm not confident this is the right way to implement the change you want. |
That's the file that controls which tests are run on the aux builder. It is the only file where we could possibly implement this change. |
Oh I see, there are two kind of jobs, those that set SCRIPT and those that use this mechanism. I'll approve this since it's just following the existing pattern but I feel like at some point we were trying to get away from Makefiles? @bors r+ |
Yeah this makefile feels like a relict from the past. But I don't have it in me to understand enough of our CI pipeline to clean this up.
|
@bors rollup=iffy |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 99426c5 (parent) -> b17dba4 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard b17dba45186c454576d0fc8fb93ecc65eb1a763a --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (b17dba4): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary -2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 744.362s -> 743.703s (-0.09%) |
Miri now supports running doctests across different targets. Let's use that to run the std doctests on aarch64-apple-darwin, i686-pc-windows-msvc.
try-job: x86_64-gnu-aux