Subtree update of `rust-analyzer` #142567

lnicola · 2025-06-16T09:01:29Z

r? @ghost

`#[cfg_attr]` is a builtin attr, but it may still contain a macro.

…-two Make `Semantics<'db, DB>` support `Semantics<'db, dyn HirDatabase>`, take two

…lf: Sized` items

…items fix: Do not error at impls for unsized types that do not include `where Self: Sized` items

[minor] Fix typos

It used to decompose them thinking they were numbers.

…v-minus fix: Fix proc macro server handling of strings with minuses

fix: Hide dyn inlay hints for incomplete `impl`s

…trait-solve-invalidation hir-ty: test incremental trait solving

Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

…yarn/editors/code/brace-expansion-1.1.12 chore(deps-dev): bump brace-expansion from 1.1.11 to 1.1.12 in /editors/code

fix: Fix completion with some attribute macros

Instead of simple numbering, we hash important bits, like the name of the item. This will allow for much better incrementality, e.g. when you add an item. Currently, this invalidates the IDs of all following items, which invalidates pretty much everything.

Item tree IDs are very unstable (adding an item of a kind invalidates all following items of the same kind). Instead use ast ids, which, since the previous commit, are pretty stable.

I'm joking, but now that the def map is the only thing that uses the item tree, we can remove a lot of things from it that aren't needed for the def map.

We can do that and it's pretty heavy.

Provide better incrementality when items are changed

Doing so can cause us to duplicate navigation targets for the same ranges which breaks convenience features of some editors where go to def can trigger find all references

`ItemTree`'s `ItemVisibilities` has no identity, so deduplicate

fix: Do not force descend into derives for goto IDE features

rustbot · 2025-06-16T09:01:33Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2025-06-16T10:02:21Z

@bors r+ p=1 subtree sync

bors · 2025-06-16T10:02:23Z

📌 Commit 36f2e8f has been approved by lnicola

It is now in the queue for this repository.

bors · 2025-06-17T03:10:13Z

⌛ Testing commit 36f2e8f with merge 2113b26...

Subtree update of `rust-analyzer` r? `@ghost`

bors · 2025-06-17T04:14:55Z

💔 Test failed - checks-actions

lnicola · 2025-06-17T16:05:54Z

@bors2 try

rust-bors · 2025-06-17T16:05:58Z

⌛ Trying commit 6a9c5d7 with merge 0904302…

To cancel the try build, run the command @bors2 try cancel.

Subtree update of `rust-analyzer` r? `@ghost`

rust-bors · 2025-06-17T18:32:51Z

☀️ Try build successful (CI)
Build commit: 0904302 (090430278b1a42dc9d9aaccaf177e66d6e2b0808, parent: 55d436467c351b56253deeba209ae2553d1c243f)

lnicola · 2025-06-17T18:34:22Z

@bors r+

bors · 2025-06-17T18:34:25Z

📌 Commit 6a9c5d7 has been approved by lnicola

It is now in the queue for this repository.

bors · 2025-06-17T21:13:41Z

⌛ Testing commit 6a9c5d7 with merge 27eb269...

bors · 2025-06-18T00:16:40Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 27eb269 to master...

github-actions · 2025-06-18T00:19:44Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f3db639 (parent) -> 27eb269 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 27eb2690f4d78f0f41eaa7193a06cd49d74b2eb0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 5696.4s -> 3645.1s (-36.0%)
x86_64-apple-1: 8660.8s -> 6518.2s (-24.7%)
i686-gnu-2: 6339.0s -> 5412.2s (-14.6%)
i686-gnu-1: 8289.0s -> 7231.0s (-12.8%)
i686-gnu-nopt-1: 8043.7s -> 7042.8s (-12.4%)
dist-apple-various: 6234.5s -> 6981.0s (12.0%)
x86_64-rust-for-linux: 2914.9s -> 2571.6s (-11.8%)
x86_64-gnu-llvm-19-1: 3664.0s -> 3256.2s (-11.1%)
armhf-gnu: 5096.1s -> 4542.0s (-10.9%)
mingw-check-tidy: 75.4s -> 67.2s (-10.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-18T03:28:07Z

Finished benchmarking commit (27eb269): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -1.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-2.9%	[-4.6%, -1.6%]	10
All ❌✅ (primary)	-1.6%	[-1.6%, -1.6%]	1

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 692.654s -> 693.336s (0.10%)
Artifact size: 372.15 MiB -> 372.12 MiB (-0.01%)

regexident and others added 30 commits June 6, 2025 09:45

Make Semantics<'db, dyn HirDatabase> actually usable

50c2faa

Remove the optimization of builtin attrs in is_inside_macro_call()

a5bf989

`#[cfg_attr]` is a builtin attr, but it may still contain a macro.

Correctly handle attr macros placed in cfg_attr in speculative expansion

ac34cb4

Merge pull request rust-lang#19930 from regexident/dyn-semantics-take…

e3ec143

…-two Make `Semantics<'db, DB>` support `Semantics<'db, dyn HirDatabase>`, take two

Do not error at impls for unsized types that do not include `where Se…

95fdb2d

…lf: Sized` items

Merge pull request rust-lang#19963 from ChayimFriedman2/unsized-impl-…

b64e748

…items fix: Do not error at impls for unsized types that do not include `where Self: Sized` items

[minor] Fix typos

bb4a1ec

Merge pull request rust-lang#19964 from Wilfred/fix_typos

2747247

[minor] Fix typos

Fix proc macro server handling of strings with minuses

3c10e1a

It used to decompose them thinking they were numbers.

Merge pull request rust-lang#19970 from ChayimFriedman2/proc-macro-sr…

1f1cb5d

…v-minus fix: Fix proc macro server handling of strings with minuses

fix: Hide dyn inlay hints for incomplete impls

ac4e365

Merge pull request rust-lang#19973 from Veykril/push-ppltxvqvqmkk

6e5439b

fix: Hide dyn inlay hints for incomplete `impl`s

hir-ty: test (the absence of) incremental trait solving

fb169ff

Merge pull request rust-lang#19975 from davidbarsky/davidbarsky/test-…

b0055c9

…trait-solve-invalidation hir-ty: test incremental trait solving

Merge pull request rust-lang#19979 from rust-lang/dependabot/npm_and_…

75ab15b

…yarn/editors/code/brace-expansion-1.1.12 chore(deps-dev): bump brace-expansion from 1.1.11 to 1.1.12 in /editors/code

Merge pull request rust-lang#19942 from ChayimFriedman2/faux

499e0dd

fix: Fix completion with some attribute macros

Use stable AST IDs

8e06cef

Instead of simple numbering, we hash important bits, like the name of the item. This will allow for much better incrementality, e.g. when you add an item. Currently, this invalidates the IDs of all following items, which invalidates pretty much everything.

Avoid referring to the item tree except in the def map

cd1298a

Item tree IDs are very unstable (adding an item of a kind invalidates all following items of the same kind). Instead use ast ids, which, since the previous commit, are pretty stable.

Remove most of the item tree

bb5f1bf

I'm joking, but now that the def map is the only thing that uses the item tree, we can remove a lot of things from it that aren't needed for the def map.

Ignore ast id hashes in typos check

c09ac19

LRU ast id map

1babfe7

We can do that and it's pretty heavy.

Merge pull request rust-lang#19837 from ChayimFriedman2/stable-astid

fa7a6c1

Provide better incrementality when items are changed

ItemTree's ItemVisibilities has no identity, so deduplicate

c1d0859

fix: Do not force descend into derives for goto IDE features

2972e77

Doing so can cause us to duplicate navigation targets for the same ranges which breaks convenience features of some editors where go to def can trigger find all references

Merge pull request rust-lang#19980 from Veykril/push-qsuttvtvtytr

e7ae390

`ItemTree`'s `ItemVisibilities` has no identity, so deduplicate

Merge pull request rust-lang#19981 from Veykril/push-tzzunsrqqunv

80dd145

fix: Do not force descend into derives for goto IDE features

Remove ItemTreeId

d4a3719

Remove FileItemTreeId

a265cdd

AttrOwner needs no ModItem

834579f

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2025

bors added a commit that referenced this pull request Jun 17, 2025

Auto merge of #142567 - lnicola:sync-from-ra, r=lnicola

2113b26

Subtree update of `rust-analyzer` r? `@ghost`

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 17, 2025

Try to downgrade object

6a9c5d7

rust-bors bot added a commit that referenced this pull request Jun 17, 2025

Auto merge of #142567 - lnicola:sync-from-ra, r=<try>

0904302

Subtree update of `rust-analyzer` r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2025

bors mentioned this pull request Jun 17, 2025

Rewrite inline attribute parser to use new infrastructure and improve diagnostics for all parsed attributes #138165

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 18, 2025

bors merged commit 27eb269 into rust-lang:master Jun 18, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 18, 2025

lnicola deleted the sync-from-ra branch June 18, 2025 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Subtree update of `rust-analyzer` #142567

Subtree update of `rust-analyzer` #142567

Uh oh!

lnicola commented Jun 16, 2025

Uh oh!

rustbot commented Jun 16, 2025

Uh oh!

lnicola commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

bors commented Jun 17, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 17, 2025

Uh oh!

lnicola commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

lnicola commented Jun 17, 2025

Uh oh!

bors commented Jun 17, 2025

Uh oh!

bors commented Jun 17, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

rust-timer commented Jun 18, 2025

Uh oh!

Uh oh!

Subtree update of rust-analyzer #142567

Subtree update of rust-analyzer #142567

Uh oh!

Conversation

lnicola commented Jun 16, 2025

Uh oh!

rustbot commented Jun 16, 2025

Uh oh!

lnicola commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

bors commented Jun 17, 2025

Uh oh!

This comment has been minimized.

bors commented Jun 17, 2025

Uh oh!

lnicola commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

lnicola commented Jun 17, 2025

Uh oh!

bors commented Jun 17, 2025

Uh oh!

bors commented Jun 17, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 18, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Subtree update of `rust-analyzer` #142567

Subtree update of `rust-analyzer` #142567