Skip to content

Add note about str::split handling of no matches. #142779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Add note about str::split handling of no matches. #142779

merged 1 commit into from
Jun 24, 2025
+6 −0

Conversation

Erk-
Copy link
Contributor

@Erk- Erk- commented Jun 20, 2025 •
edited by rustbot
Loading

Adds small note and example to the test for a non matching pattern

resolves #142734

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2025
@rustbot

This comment has been minimized.

Sign in to view
@Erk- Erk- force-pushed the fix/core/142734 branch from dba8e89 to 0be168e Compare June 20, 2025 11:59
@jhpratt
Copy link
Member

jhpratt commented Jun 24, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 24, 2025

📌 Commit 0be168e has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 24, 2025
Merged
bors added a commit that referenced this pull request Jun 24, 2025
@bors
Auto merge of #142956 - GuillaumeGomez:rollup-867246h, r=GuillaumeGomez
36b2163 
Rollup of 9 pull requests

Successful merges:

 - #140005 (Set MSG_NOSIGNAL for UnixStream)
 - #140622 (compiletest: Improve diagnostics for line annotation mismatches)
 - #142354 (Fixes firefox copy paste issue)
 - #142695 (Port `#[rustc_skip_during_method_dispatch]` to the new attribute system)
 - #142779 (Add note about `str::split` handling of no matches.)
 - #142894 (phantom_variance_markers: fix identifier usage in macro)
 - #142928 (Fix hang in --print=file-names in bootstrap)
 - #142932 (rustdoc-json: Keep empty generic args if parenthesized)
 - #142933 (Simplify root goal API of solver a bit)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 673ce2a into rust-lang:master Jun 24, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 24, 2025
rust-timer added a commit that referenced this pull request Jun 24, 2025
@rust-timer
Unrolled build for #142779
c9f7d9f 
Rollup merge of #142779 - Erk-:fix/core/142734, r=jhpratt

Add note about `str::split` handling of no matches.

Adds small note and example to the test for a non matching pattern

resolves #142734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhpratt jhpratt

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.

str::split does not clarify what happens when there is no match
4 participants
@Erk- @rustbot @jhpratt @bors