Put spans in all parsed attributes

[mejrs]

Fixes #142783

Alternative to #142552.

This PR is more wordy than it strictly has to be because it also changes the AttributeKind enum to have exclusively named fields.(my ocd cannot stand enums with mixed named and tuple fields)

cc @GrigorenkoPV
r? @jdonszelmann

[rustbot]

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

[rustbot]

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

[jdonszelmann]

I'm very much against this. About to head to bed, but I don't think this is the best way forward. Will say more tomorrow

[mejrs]

I don't disagree but if we don't do something then that ICE is going to keep popping up.

[rust-log-analyzer]

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    |                                                ^^^^^^^^^^^^^^^^^^^^^^^ not a tuple struct or tuple variant
    |
help: the struct variant's field is being ignored
    |
763 -                         hir::Attribute::Parsed(AttributeKind::Repr(..)) => None,
763 +                         hir::Attribute::Parsed(AttributeKind::Repr { reprs: _ }) => None,
    |

For more information about this error, try `rustc --explain E0164`.
[RUSTC-TIMING] rustdoc test:false 3.175
error: could not compile `rustdoc` (lib) due to 1 previous error

[bors]

☔ The latest upstream changes (presumably #142794) made this pull request unmergeable. Please resolve the merge conflicts.

[jdonszelmann]

mhm, I had somewhat accepted that that's an ICE that's going to sporadically appear and when it does we'll locally fix it. For example, in the case of that issue we just also convert track_caller to a new attribute

[jdonszelmann]

alright, closing this one. Feel free to file just the field change on its own!