Skip to content

Add sym::macro_pin diagnostic item for core::pin::pin!() #143015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samueltardieu
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 25, 2025
@samueltardieu
Copy link
Contributor Author

I need this for Clippy (rust-lang/rust-clippy#15120).

@Urgau
Copy link
Member

Urgau commented Jun 25, 2025

r=me when CI is green

r? Urgau
@bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

✌️ @samueltardieu, you can now approve this pull request!

If @Urgau told you to "r=me" after making some further change, please make that change, then do @bors r=@Urgau

@samueltardieu
Copy link
Contributor Author

samueltardieu commented Jun 25, 2025

@bors r=@Urgau

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

📌 Commit b75b14f has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025
@samueltardieu
Copy link
Contributor Author

@bors rollup=always

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jun 26, 2025
… r=Urgau

Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 26, 2025
… r=Urgau

Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`
bors added a commit that referenced this pull request Jun 26, 2025
Rollup of 17 pull requests

Successful merges:

 - #124595 (Suggest cloning `Arc` moved into closure)
 - #139594 (Simplify `ObligationCauseCode::IfExpression`)
 - #141311 (make `tidy-alphabetical` use a natural sort)
 - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion)
 - #142255 (Add edition checks for some tests that had divergent output)
 - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
 - #142549 (small iter.intersperse.fold() optimization)
 - #142637 (Remove some glob imports from the type system)
 - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation)
 - #142700 (Remove incorrect comments in `Weak`)
 - #142884 (StableMIR: Add method to retrieve body of coroutine)
 - #142925 (Rewrite `.gitattributes` CRLF ui tests into run-make tests)
 - #143001 (Rename run always )
 - #143010 (Update `browser-ui-test` version to `0.20.7`)
 - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`)
 - #143020 (codegen_fn_attrs: make comment more precise)
 - #143033 (Expand const-stabilized API links in relnotes)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2025
… r=Urgau

Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 26, 2025
… r=Urgau

Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants