Make the match arm type mismatch message point to the arm's span #14561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| match trace.origin.note_span() { | ||
| Some(span) => { | ||
| let note_str = match trace.origin { |
|
@huonw Agreed. Comments addressed. |
| }; | ||
| match note { | ||
| Some((note_span, note_str)) => | ||
| self.tcx.sess.span_note(note_span, note_str), |
There was a problem hiding this comment.
Why can't this just be called directly in the trace.origin match? (It can be split into two matches later, if anything else needs a note.)
|
@huonw Addressed and squashed. |
bors
added a commit
that referenced
this pull request
Jun 1, 2014
ghost
deleted the
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…=Veykril feat: Map tokens from `include!` expansion to the included file Fixes rust-lang/rust-analyzer#3767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11319