Improve error messages for io::fs #14629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,6 +135,8 @@ impl File { | |||
| last_nread: -1 | |||
| } | |||
| }) | |||
| }).update_err("Couldn't open file", |e| { | |||
There was a problem hiding this comment.
Our convention, at least for the compiler, is to start with lowercase letters as opposed to uppercase letters.
|
I believe I have responded to all of your comments. 😄 |
|
I'll rebase and take over from here (talked with @wycats on IRC) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
internal: Add some additional status ouput We should be able to use this infra to get a better grasp about what we might want to LRU
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2025
- Do not replace macro results in then/else branches - Extract condition snippet from the right context - Make suggestion `MaybeIncorrect` if it would lead to losing comments changelog: [`bool_to_int_with_if`]: properly handle macros Fixes rust-lang/rust-clippy#14628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the error descriptions and details for the functions and methods exposed in
io::fs.The basic idea is that the description should always map onto the high-level operation that the user was trying to perform, with the
detailcontaining the original message. TheIoErrorKindis always maintained. Thedetailalso includes additional information (most notably the relevant path, but also other parameters or contextual information).I added an
UpdateIoErrortrait to make it easier to do these in-place modification, and I'm eager for feedback on the specific strategy.