Add visit_attribute to Visitor, use it for unused_attribute #14741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1836,7 +1835,6 @@ impl<'a> Visitor<()> for Context<'a> { | |||
| check_heap_item(cx, it); | |||
| check_missing_doc_item(cx, it); | |||
| check_attrs_usage(cx, it.attrs.as_slice()); | |||
There was a problem hiding this comment.
Can this move to visit_attribute too?
There was a problem hiding this comment.
The attribute usage lint has separate handling of crate and non-crate attributes, so it wouldn't work well in visit_attribute. I've actually been meaning to delete the attribute_usage lint since it's superseded by unused_attribute. Maybe that should just happen now.
The lint was missing a *lot* of cases previously.
It has been superseded by the unused_attribute lint. [breaking change]
|
Updated |
bors
added a commit
that referenced
this pull request
Jun 8, 2014
The lint was missing a *lot* of cases previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint was missing a lot of cases previously.