Skip to content

Place TaskPool comment so it documents struct #14993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2014
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/libstd/sync/task_pool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![allow(missing_doc)]

/// A task pool abstraction. Useful for achieving predictable CPU
/// parallelism.
//! Abstraction of a task pool for basic parallelism.

use core::prelude::*;

Expand All @@ -25,6 +22,7 @@ enum Msg<T> {
Quit
}

/// A task pool used to execute functions in parallel.
pub struct TaskPool<T> {
channels: Vec<Sender<Msg<T>>>,
next_index: uint,
Expand All @@ -40,11 +38,13 @@ impl<T> Drop for TaskPool<T> {
}

impl<T> TaskPool<T> {
/// Spawns a new task pool with `n_tasks` tasks. If the `sched_mode`
/// is None, the tasks run on this scheduler; otherwise, they run on a
/// new scheduler with the given mode. The provided `init_fn_factory`
/// returns a function which, given the index of the task, should return
/// local data to be kept around in that task.
/// Spawns a new task pool with `n_tasks` tasks. The provided
/// `init_fn_factory` returns a function which, given the index of the
/// task, should return local data to be kept around in that task.
///
/// # Failure
///
/// This function will fail if `n_tasks` is less than 1.
pub fn new(n_tasks: uint,
init_fn_factory: || -> proc(uint):Send -> T)
-> TaskPool<T> {
Expand Down Expand Up @@ -87,12 +87,16 @@ impl<T> TaskPool<T> {

#[test]
fn test_task_pool() {
let f: || -> proc(uint):Send -> uint = || {
let g: proc(uint):Send -> uint = proc(i) i;
g
};
let f: || -> proc(uint):Send -> uint = || { proc(i) i };
let mut pool = TaskPool::new(4, f);
for _ in range(0, 8) {
pool.execute(proc(i) println!("Hello from thread {}!", *i));
}
}

#[test]
#[should_fail]
fn test_zero_tasks_failure() {
let f: || -> proc(uint):Send -> uint = || { proc(i) i };
TaskPool::new(0, f);
}